From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 219CDEB64DC for ; Tue, 11 Jul 2023 14:26:19 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 56091FF3; Tue, 11 Jul 2023 16:25:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 56091FF3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1689085577; bh=C71aeTJAOI/hMDyIcMR24A6iht2n+gbfSGfP4xzAt6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=CoE3MJ+K7xE9gJCQXd3u510EXJ38ZoarD218gqDHqMHLQSS3AUTPkbM+JU6gymqG1 JlKhWLqoynz6GZTkVjTj5VLUlQP0y9mniRRmn78n4mU93r9EWyDxloaCgDFWvLN8Lm qr5VfZ+4+fCcbWH7e2Ef4AVS/wT1fB4UDm0TacII= Received: by alsa1.perex.cz (Postfix, from userid 50401) id A1239F80617; Tue, 11 Jul 2023 16:22:04 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2A1C2F80617; Tue, 11 Jul 2023 16:22:04 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B3E88F80236; Tue, 11 Jul 2023 13:11:00 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 11A55F800E4 for ; Tue, 11 Jul 2023 13:10:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 11A55F800E4 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=aIsWaM+J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689073859; x=1720609859; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=C71aeTJAOI/hMDyIcMR24A6iht2n+gbfSGfP4xzAt6Q=; b=aIsWaM+JjpIAev3ppRwB49R9/tFLEibjDKFz3xdVuIBpdjV5UZXWoEmo pof1av+qtvUyH3HkPIvX6IclmYdga2BRKvbdAxC7CZafqQKLbxHpZ8QaP DVFv5Ng+E+6HtTyflOLbaHuAK87iyicpIZJjaf3n59ZkR7ynGm09tz5E4 O8B3OVJ/Gw5IjuFMglyscSObwPO9XdRN6oaCIsnz5o7rybkerR6d3DLr5 1RLleBG/oUVTgfy/GrMmETsse7axSu/H06IcutmsyeeIzg5J1PqxGyyTD ZVXXrS+D2PVqSq3efFYFSCvUVSfzxPAZzlK8X08Ysh+nbLHqcTgrx2lpC w==; X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="363454809" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="363454809" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2023 04:10:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="756326203" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="756326203" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 11 Jul 2023 04:10:42 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qJBGQ-001pHZ-2T; Tue, 11 Jul 2023 14:10:38 +0300 Date: Tue, 11 Jul 2023 14:10:38 +0300 From: Andy Shevchenko To: Mark Brown Cc: Cristian Ciocaltea , Yang Yingliang , Amit Kumar Mahapatra via Alsa-devel , Neil Armstrong , Tharun Kumar P , Vijaya Krishna Nivarthi , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, Sanjay R Mehta , Radu Pirea , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Tudor Ambarus , Serge Semin , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Andy Gross , Bjorn Andersson , Konrad Dybcio , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Max Filippov , Steven Rostedt , Masami Hiramatsu , Richard Cochran Subject: Re: [PATCH v2 08/15] spi: Clean up headers Message-ID: References: <20230710154932.68377-1-andriy.shevchenko@linux.intel.com> <20230710154932.68377-9-andriy.shevchenko@linux.intel.com> <54bb9fe7-fb62-4c2e-ae36-d2c10648ee27@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54bb9fe7-fb62-4c2e-ae36-d2c10648ee27@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Hits: max-recipients X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-size; news-moderation; no-subject; digests; suspicious-header Message-ID-Hash: JJ3467CXKVYBJZHJEQIE4XL62DHCES3P X-Message-ID-Hash: JJ3467CXKVYBJZHJEQIE4XL62DHCES3P X-Mailman-Approved-At: Tue, 11 Jul 2023 14:21:49 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Jul 10, 2023 at 06:21:44PM +0100, Mark Brown wrote: > On Mon, Jul 10, 2023 at 06:49:25PM +0300, Andy Shevchenko wrote: > > There is a few things done: > > - include only the headers we are direct user of > > - when pointer is in use, provide a forward declaration > > - add missing headers > > - group generic headers and subsystem headers > > - sort each group alphabetically > > The previous commit was supposed to be sorting things and AFAICT did > so... This is about forward declaration groups. > > +struct spi_device_id; > > Why are we adding this given that there's also an inclusion of > mod_devicetable that you didn't remove? Answered in the other email. -- With Best Regards, Andy Shevchenko