From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CA6FEB64DD for ; Tue, 11 Jul 2023 14:28:01 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DCE1B1502; Tue, 11 Jul 2023 16:27:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DCE1B1502 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1689085678; bh=fixFH5Llqroff/AhZ015VZ+OpUUgSBQ7xNlXodB8idQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ru04ZBIk9JFoEkSFPtwroqLDxx2c32FdfVTl9mfAzzzAUkQ7tUkiMgbRv+oy/FSem xFRMWXx1hdeTnOe4MW5cWhNt7laZWiWXddLezkvzjNkv4BDRBsvVhRIfV+vPQmEdVI gtvQ4ScatI94oTU4EMwJSPWxzOd5kRWzeI+Dm8ds= Received: by alsa1.perex.cz (Postfix, from userid 50401) id CEDEDF80249; Tue, 11 Jul 2023 16:22:19 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id E75B5F8067A; Tue, 11 Jul 2023 16:22:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 937F6F80249; Tue, 11 Jul 2023 14:52:14 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 91D55F800E4 for ; Tue, 11 Jul 2023 14:52:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 91D55F800E4 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=GRr45l5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689079931; x=1720615931; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fixFH5Llqroff/AhZ015VZ+OpUUgSBQ7xNlXodB8idQ=; b=GRr45l5DBmmc/9UmCGAeyY/3Tbo9o8wkFFxrNlhb467IUlz/IGWGHaqq O8+qVwhxVwPxpYURZ2lpxB44pUBxntk3IPYcPcIMCicBb5Hi/tmbcXsXs C/Ao1fOpFLYUfOLHeKvN1cAl4Y7hUd5EsVVi3RhO1yWknjX1HVDTHBGZY RTMUNKwk3QSjJca25InW997aI6ruov8VTWoai5Eh4trjD6zLLHXnsazGv j6QiFozYgFqA+xkhINL4H83smUSUSFlY2fLiiRhRocQHAVozGgWYpAo2f 38QnGcnwfgT2MIMtszJN5uqfss/+EN/1CBpoeHs/D8s4uvyHBha7AjZBJ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10768"; a="344205674" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="344205674" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2023 05:52:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10768"; a="786613329" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="786613329" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 11 Jul 2023 05:51:56 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qJCqO-001qnp-39; Tue, 11 Jul 2023 15:51:52 +0300 Date: Tue, 11 Jul 2023 15:51:52 +0300 From: Andy Shevchenko To: AngeloGioacchino Del Regno Cc: Mark Brown , Cristian Ciocaltea , Yang Yingliang , Amit Kumar Mahapatra via Alsa-devel , Neil Armstrong , Tharun Kumar P , Vijaya Krishna Nivarthi , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, Sanjay R Mehta , Radu Pirea , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Tudor Ambarus , Serge Semin , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , Andy Gross , Bjorn Andersson , Konrad Dybcio , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Max Filippov , Steven Rostedt , Masami Hiramatsu , Richard Cochran Subject: Re: [PATCH v2 01/15] spi: Remove unneeded OF node NULL checks Message-ID: References: <20230710154932.68377-1-andriy.shevchenko@linux.intel.com> <20230710154932.68377-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Hits: max-recipients X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-size; news-moderation; no-subject; digests; suspicious-header Message-ID-Hash: 5DFNLO32LAACOPMK3V2BKALSRMCWB34O X-Message-ID-Hash: 5DFNLO32LAACOPMK3V2BKALSRMCWB34O X-Mailman-Approved-At: Tue, 11 Jul 2023 14:22:03 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Jul 11, 2023 at 10:12:55AM +0200, AngeloGioacchino Del Regno wrote: > Il 10/07/23 17:49, Andy Shevchenko ha scritto: > > In the couple of places the NULL check of OF node is implied by the call > > that takes it as a parameter. Drop the respective duplicate checks. > > > > Signed-off-by: Andy Shevchenko > > Validated against spi-mt65xx, spi-mt7621, spi-mtk-nor, spi-mtk-snfi; > > Reviewed-by: AngeloGioacchino Del Regno > # MediaTek By some reason the tag is split and I'm not sure `b4` can cope with that. In any case, added manually. Thank you for the review! -- With Best Regards, Andy Shevchenko