From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B87EEB64DD for ; Mon, 3 Jul 2023 12:22:08 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C5BD0203; Mon, 3 Jul 2023 14:21:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C5BD0203 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1688386925; bh=iVpVYys+6HpIG93JCxQUvBWe/5NbR/bCynk6NtjIifE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ra8dKdHr0pohfWVMn6wEbTVq7a+0VORuTKUy4T3OcMGFFXeQREMHORGoBcwI8uVE0 nSQj/orf5WmDrlMuN9VAWVf4D6gGp2HWuznxVU7pGvTZpwR0XjhFUTdbACqHVjAtxI eq984d2il9SuCg7+YTlcetqeZ293eVbW2vflcsWA= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3A68EF80093; Mon, 3 Jul 2023 14:21:15 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 00B6EF80125; Mon, 3 Jul 2023 14:21:15 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3A786F80125; Mon, 3 Jul 2023 14:21:12 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1EA71F80104 for ; Mon, 3 Jul 2023 14:21:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1EA71F80104 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=s2vK617R Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 067CB60F24; Mon, 3 Jul 2023 12:21:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C723BC433C7; Mon, 3 Jul 2023 12:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688386866; bh=iVpVYys+6HpIG93JCxQUvBWe/5NbR/bCynk6NtjIifE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s2vK617R6XxCCO41svbYSKf3ouMwj1fyD898WRlATYojK40HeGQHlMW2yPeRt5q37 ltn+iRBycdtcpufxn9hTiQse+Wmtz0bTwj5KqkRAElOidoHI+DnkpACnY+7VviNixS uOpY/aF61DdUS2PaZUQ1erZnUfhCOKXUOUEBMJUrbmOuGUxk+Jjm9/9R0Qlp6FsToL qwpAJAZp+1pHfoV9kWbj/IC8RdHN54aPt+vq0MPBd7PsClfph58N47VSR8BqXmWUwI K+54vCmWx/ZBPg+Q89kOfeO43OZ/+LgbL3GweVUC1J4qixnRqk9klGP/TBjdH+2hnk a1OoBo3j9dmNw== Received: from johan by xi.lan with local (Exim 4.96) (envelope-from ) id 1qGIYS-0001My-31; Mon, 03 Jul 2023 14:21:21 +0200 Date: Mon, 3 Jul 2023 14:21:20 +0200 From: Johan Hovold To: Takashi Iwai Cc: Srinivas Kandagatla , Mark Brown , johan+linaro@kernel.org, perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, Stable@vger.kernel.org Subject: Re: [PATCH] ASoC: qdsp6: q6apm: use dai link pcm id as pcm device number Message-ID: References: <20230628092404.13927-1-srinivas.kandagatla@linaro.org> <877crh76ge.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Message-ID-Hash: O7XWFZ2ELRDDYKWWAIZWZBVWWJE7QLSE X-Message-ID-Hash: O7XWFZ2ELRDDYKWWAIZWZBVWWJE7QLSE X-MailFrom: johan@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Jul 03, 2023 at 10:48:51AM +0200, Johan Hovold wrote: > On Mon, Jul 03, 2023 at 10:19:29AM +0200, Takashi Iwai wrote: > > On Mon, 03 Jul 2023 10:03:52 +0200, > > Johan Hovold wrote: > > > > Ok, scratch that. I just hit the race again also with this patch > > > applied: > > > > > > [ 11.815028] q6apm-dai 3000000.remoteproc:glink-edge:gpr:service@1:dais: Adding to iommu group 23 > > > [ 11.838667] snd-sc8280xp sound: ASoC: adding FE link failed > > > [ 11.838774] snd-sc8280xp sound: ASoC: topology: could not load header: -517 > > > [ 11.838916] qcom-apm gprsvc:service:2:1: tplg component load failed-517 > > > [ 11.838996] qcom-apm gprsvc:service:2:1: ASoC: error at snd_soc_component_probe on gprsvc:service:2:1: -22 > > > [ 11.839430] snd-sc8280xp sound: ASoC: failed to instantiate card -22 > > > [ 11.844801] snd-sc8280xp: probe of sound failed with error -22 > > > > Isn't it rather an issue about the error code passing in qcom driver? > > How about the change like below? > > Indeed, and I tested a change like that here: > > https://lore.kernel.org/lkml/ZIHSGf18Aw7htb9o8@hovoldconsulting.com/ That link was missing was apparently broken, should have been: https://lore.kernel.org/all/ZIHSGf18w7htb9o8@hovoldconsulting.com/ > > but that only seems to make the problem worse currently. > > This should probably still be fixed, but I was just hoping that the DAI > numbering could have been the cause for the probe deferral (which then > triggers the other bugs). Johan