From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECA27EB64DA for ; Mon, 10 Jul 2023 12:39:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 281CD206; Mon, 10 Jul 2023 14:38:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 281CD206 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1688992789; bh=2I7Ns5P9Fqk5itIQUPMwgPj6Db+DdMBwViqY3DgUc6U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=sUpzUMPLTSU6ksLDGj++19VQWSAAnlCLgR64E1AU5Evk68gCl9lLPC9akNtIAl0oa UHWJiQjmJa/qSIrwcv3H6em9kNcMeT/46qaLY119u+zINkNnqcYb+VLLOObgR4rS3c vJSvENlJ6r2JEtXbrrE0avS+3rSixCWQS/dyRbcg= Received: by alsa1.perex.cz (Postfix, from userid 50401) id BBB0AF80290; Mon, 10 Jul 2023 14:38:32 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 3E921F80249; Mon, 10 Jul 2023 14:38:32 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F2FB5F80249; Mon, 10 Jul 2023 14:38:26 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E154BF800D2 for ; Mon, 10 Jul 2023 14:38:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E154BF800D2 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=B+4okRfM DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688992697; x=1720528697; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=2I7Ns5P9Fqk5itIQUPMwgPj6Db+DdMBwViqY3DgUc6U=; b=B+4okRfMay5cKaUdBt+YXEUfYbqaTA4Kasu+YT9xdGmni+KVM17qmUxL PnfFtglMyqBYqNL6iIEuj2rH5anMQrdEzzi1SZhtT5OCSqn9jyc/mxMyB UwtRgApnYc0mCFdK1HW4prul0fzeFMlMfMAiw7zJtPXYUjX9Tr/5CsoDj TcUZ/gCOdOLOdHe7YtsXA+/16lFc5n5G4KFDI+d5qcpw8BiyHUIMAl2qU wrLISuggLyOod80bm9px8ON9cpdW+hAZzfv0ct9P/BthW2d6XVDQH/sqf OX/11tcqVnx8m9a65xIUJ9Q1wmSExLJ9BFy8RCbojm/Lh4NC+ULaJDtDJ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="428025540" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="428025540" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 05:38:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="755983743" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="755983743" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 10 Jul 2023 05:38:02 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qIq9Q-001YUr-0L; Mon, 10 Jul 2023 15:38:00 +0300 Date: Mon, 10 Jul 2023 15:37:59 +0300 From: Andy Shevchenko To: Mark Brown Cc: Yang Yingliang , Amit Kumar Mahapatra via Alsa-devel , Kris Bahnsen , Neil Armstrong , Tharun Kumar P , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, Radu Pirea , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Tudor Ambarus , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Max Filippov , Richard Cochran Subject: Re: [PATCH v1 4/8] spi: Get rid of old SPI_MASTER_NO_.X and SPI_MASTER_MUST_.X Message-ID: References: <20230710102751.83314-1-andriy.shevchenko@linux.intel.com> <20230710102751.83314-5-andriy.shevchenko@linux.intel.com> <1ffd5603-4140-4bf6-bfed-af70a6759bda@sirena.org.uk> <353027bf-6d2a-40de-9e18-8553864b343c@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <353027bf-6d2a-40de-9e18-8553864b343c@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Message-ID-Hash: Z5K7LSNFISGXGWC7AQMVDR2N3TYWZQSF X-Message-ID-Hash: Z5K7LSNFISGXGWC7AQMVDR2N3TYWZQSF X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Jul 10, 2023 at 12:22:59PM +0100, Mark Brown wrote: > On Mon, Jul 10, 2023 at 02:10:53PM +0300, Andy Shevchenko wrote: > > On Mon, Jul 10, 2023 at 02:08:00PM +0300, Andy Shevchenko wrote: > > > On Mon, Jul 10, 2023 at 12:04:35PM +0100, Mark Brown wrote: > > > > On Mon, Jul 10, 2023 at 01:27:47PM +0300, Andy Shevchenko wrote: > > > > > > Convert the users to SPI_CONTROLLER_NO_?X and SPI_CONTROLLER_MUST_.X > > > > > and kill the not used anymore definitions. > > > > > The above is not what this change does: > > > > How to improve it? I was sure that the form of "converting to something and > > > something" is clear... > > > A wild guess, maybe you meant to split to two changes, one per each macro group? > > No, doing TX and RX in one commit is fine. No, I meant one per _NO_ and _MUST_. > > > > > - controller->flags = SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX; > > > > > + controller->flags = SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX; > > What part of the above change is replacing _NO_ with _MUST_? None, that's why assuming the split by name should be fine. -- With Best Regards, Andy Shevchenko