From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2A1DEB64D9 for ; Mon, 10 Jul 2023 11:09:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 21EF883A; Mon, 10 Jul 2023 13:09:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 21EF883A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1688987390; bh=VFbT1YSYy4BNeDq7qC0WXbC9ofiSs7SR6qU8CkE8Ddw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=eZvjv4bHgtAGg7fY4loaxbwZTtwPwpkaqOvFonYbKXTeWuTSFcxaK0klWYm1+VymB KohASAEC088THVd8UeiFA3EJ9wp2v6Op0U/psOqKbQcuHz4QndLeT6R58/FsQJ02hu h9VoWYad2ujnXVTewGKVKQ7Z3AXT+umeOzQCjY30= Received: by alsa1.perex.cz (Postfix, from userid 50401) id F066DF80153; Mon, 10 Jul 2023 13:08:27 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id EC355F8047D; Mon, 10 Jul 2023 13:08:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A825FF80249; Mon, 10 Jul 2023 13:08:19 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8A5C4F80093 for ; Mon, 10 Jul 2023 13:08:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8A5C4F80093 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=TqELvSo/ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688987295; x=1720523295; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VFbT1YSYy4BNeDq7qC0WXbC9ofiSs7SR6qU8CkE8Ddw=; b=TqELvSo/cfdcdurExCQK6h8fyqlYOBQch7Y9DMXlowTGKmCGUvCl4XOB Hiksy6NIzoYKyX7UGDIab17suJVjnESPmgiSaM2S/7KHoXEo1H+zfw+ZJ tHDdMI0QRe1pw/K3lHBPNYSAkTdVhdCjx2gOgt6TQ5+gP53UW1Y/3XqMw YzNoGfnppVubkfn7kO/AxFONAwgZICLiG/2fuaLfMRIyz6tIgIIz8tcd1 L3z8/c512EnkFCb4zSFNorWf//a6VdSNpw1LD0So6PnvHEmvNkZD/qwmO bAEVjTnhP4xJS47c3W6TNwvklRLb/NA25dOEPMkcmqmDMxr2t5tQH2rJj g==; X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="349117626" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="349117626" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 04:08:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="967393168" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="967393168" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 10 Jul 2023 04:08:03 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qIokK-001XII-18; Mon, 10 Jul 2023 14:08:00 +0300 Date: Mon, 10 Jul 2023 14:08:00 +0300 From: Andy Shevchenko To: Mark Brown Cc: Yang Yingliang , Amit Kumar Mahapatra via Alsa-devel , Kris Bahnsen , Neil Armstrong , Tharun Kumar P , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, Radu Pirea , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Tudor Ambarus , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Max Filippov , Richard Cochran Subject: Re: [PATCH v1 4/8] spi: Get rid of old SPI_MASTER_NO_.X and SPI_MASTER_MUST_.X Message-ID: References: <20230710102751.83314-1-andriy.shevchenko@linux.intel.com> <20230710102751.83314-5-andriy.shevchenko@linux.intel.com> <1ffd5603-4140-4bf6-bfed-af70a6759bda@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ffd5603-4140-4bf6-bfed-af70a6759bda@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Message-ID-Hash: KBYGTTWZQWCOKWD7BUQMXUST2YCZXMXL X-Message-ID-Hash: KBYGTTWZQWCOKWD7BUQMXUST2YCZXMXL X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Jul 10, 2023 at 12:04:35PM +0100, Mark Brown wrote: > On Mon, Jul 10, 2023 at 01:27:47PM +0300, Andy Shevchenko wrote: > > > Convert the users to SPI_CONTROLLER_NO_?X and SPI_CONTROLLER_MUST_.X > > and kill the not used anymore definitions. > > The above is not what this change does: How to improve it? I was sure that the form of "converting to something and something" is clear... > > - controller->flags = SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX; > > + controller->flags = SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX; -- With Best Regards, Andy Shevchenko