From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CC5EC001DC for ; Wed, 26 Jul 2023 04:58:34 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8FBDD820; Wed, 26 Jul 2023 06:57:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8FBDD820 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1690347511; bh=jOeF8cppzlPBCIFSmBztXHTHPsxcIlXUKSUY753sPaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=GNbXUzLYYmWhVo2iPBcPKs0+h8ysB/ZwyfINiWkKcvJdajC7S4mGN1lBfovsL3aKh tPoSxLyJWyrDjehKpBxWUDV/mbGPkcfiPkpH/zPwvnD/FqBfb+0ROMbxDH7mYfWXAK Ke9w/0rrraUGEYTTw1Pg9rZ6xSCSWXG6Wqlco0qQ= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1D1A5F8053B; Wed, 26 Jul 2023 06:57:38 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 8FBE0F800C7; Wed, 26 Jul 2023 06:57:38 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3DE55F8019B; Wed, 26 Jul 2023 06:55:51 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BCECEF80149 for ; Wed, 26 Jul 2023 06:55:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BCECEF80149 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=cxwcE7Of Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2143961465; Wed, 26 Jul 2023 04:55:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC2E3C433C7; Wed, 26 Jul 2023 04:55:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690347339; bh=jOeF8cppzlPBCIFSmBztXHTHPsxcIlXUKSUY753sPaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cxwcE7OfXPa1gb3qMiUZj/lC1U5j/C1r691UiAJQVkcVVAudxFcwtAGx8Wu2AcBnB 8lw24oou0sqv8AzGPDJFOusy7EgHHBLa0o5YKEMRCYKB89vjV3tpZvC17ICy6u/8X6 wk9O06Fvrp3aj5VQ4wyFnph/ve5zGaqkPJNX5ABraRKfX98byGF+KGkHOPeLYldO83 LJguFqCyv0CZWxH63HcSnPxUnB+xQo2/ZUImevvR5gtdveNs84BRWD/GnRadRWkB03 xjDYrOn/ZU721oOo2Pfgdaa1cWGeddodXaPNYVMwVN/JG2S9oD+Y1Nz2p6/u6fUTNP VKL7rm/ov1IpQ== Date: Wed, 26 Jul 2023 10:25:35 +0530 From: Vinod Koul To: Robert Lee Cc: Takashi Iwai , perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: compress: add opus codec define Message-ID: References: <20230725093005.3499455-1-lerobert@google.com> <87sf9ctifg.wl-tiwai@suse.de> <87lef4thir.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Message-ID-Hash: ZGPE74PPVCFSOFVWETE773RA4WY5PGVP X-Message-ID-Hash: ZGPE74PPVCFSOFVWETE773RA4WY5PGVP X-MailFrom: vkoul@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 26-07-23, 09:47, Robert Lee wrote: Please stop top posting! > Yes, but we still need this change to let the sound system can use the > codec. or do you have any suggestions? Upstream your driver along with this change should be the way to go > > Thanks, > Robert. > > Takashi Iwai 於 2023年7月25日 週二 下午6:25寫道： > > > > On Tue, 25 Jul 2023 12:14:56 +0200, > > Robert Lee wrote: > > > > > > Thanks for reply so quickly. > > > And yes, there are other changes but it is inside our offload pcm > > > driver to handle it. > > > Currently we only use it to decode, and we don't need additional option for it. > > > > It means still a downstream-only change :) > > > > It's nice to upstream changes in general, but from the upstream POV, > > only changing this gives no benefit. Let's tie with the actual use > > case *in the upstream*. > > > > > > thanks, > > > > Takashi > > > > > > > > Thanks, > > > Robert. > > > > > > Takashi Iwai 於 2023年7月25日 週二 下午6:05寫道： > > > > > > > > On Tue, 25 Jul 2023 11:30:05 +0200, > > > > Robert Lee wrote: > > > > > > > > > > Add to support decode Opus codec in Ogg container. > > > > > > > > > > Signed-off-by: Robert Lee > > > > > > > > The change makes sense only when it's really used. So usually it's > > > > better to put into a series that actually implements its usage. > > > > > > > > > > > > thanks, > > > > > > > > Takashi > > > > > > > > > --- > > > > > include/uapi/sound/compress_params.h | 3 ++- > > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h > > > > > index ddc77322d571..bac5797bcb02 100644 > > > > > --- a/include/uapi/sound/compress_params.h > > > > > +++ b/include/uapi/sound/compress_params.h > > > > > @@ -43,7 +43,8 @@ > > > > > #define SND_AUDIOCODEC_BESPOKE ((__u32) 0x0000000E) > > > > > #define SND_AUDIOCODEC_ALAC ((__u32) 0x0000000F) > > > > > #define SND_AUDIOCODEC_APE ((__u32) 0x00000010) > > > > > -#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_APE > > > > > +#define SND_AUDIOCODEC_OPUS ((__u32) 0x00000011) > > > > > +#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_OPUS > > > > > > > > > > /* > > > > > * Profile and modes are listed with bit masks. This allows for a > > > > > -- > > > > > 2.41.0.487.g6d72f3e995-goog > > > > > > > > -- ~Vinod