From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 550B0C001B0 for ; Tue, 15 Aug 2023 13:58:32 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3C4F8741; Tue, 15 Aug 2023 15:57:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3C4F8741 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1692107910; bh=Z5boj+fMC+VijeKK6y8yvEseWJ2SPZpwxEoI0tsFjS0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=TNoUueysM1HCZqG8CywZd3LuT2RNihu6Y4vOWkCC4im1aUXeyR7nGMXTzGnIgb8uJ f2joYiDQ1rhmF2zsCGC2X2m5/jviRkjwjNmsMwPvdd+ZgvQZytAHlhaDlSsqXVt3UK MrOKZdNbwChOKyXg1Od6TpCSmdATZDAyqCrom6sU= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 430FBF80027; Tue, 15 Aug 2023 15:57:12 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id DBC3CF8016D; Tue, 15 Aug 2023 15:57:11 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 29D8AF8016D; Tue, 15 Aug 2023 15:57:08 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 07CBBF80027 for ; Tue, 15 Aug 2023 15:57:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 07CBBF80027 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=ie7ZlIBk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692107826; x=1723643826; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Z5boj+fMC+VijeKK6y8yvEseWJ2SPZpwxEoI0tsFjS0=; b=ie7ZlIBkWvKj+d8kNS36Nz/otKW/RB4WKd4b46XGWI2yqBDKGrJ8PrEp qWxU3JUF+3MiXJVj2o/voQbLisifhy6lX+rCBh7WmKtLlh28RCwOC3atL xgHO2MjauV2QdbOvSURi1qgM0tJC0NU0PFIVevTYnSwAQazmmueke4EzN ugdY9rAk5eWkFVoUuMWek9436Dc2FSi4fy7OzlDdcRThVrdSXAvRM+tBZ hYkDp0NyxgvP2Sw8bQ3eA5oSl78pCVG5gXCi1mmcPcXrTSaA9FdrIvVQb O/X4E9VghIBI0GT7HBQMNhSo8XNinyeYBMInYVMhCo16aUH6kf/XDM9Ki w==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="403259499" X-IronPort-AV: E=Sophos;i="6.01,174,1684825200"; d="scan'208";a="403259499" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2023 06:57:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="733854769" X-IronPort-AV: E=Sophos;i="6.01,174,1684825200"; d="scan'208";a="733854769" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 15 Aug 2023 06:57:00 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qVuXb-0048Sm-09; Tue, 15 Aug 2023 16:56:59 +0300 Date: Tue, 15 Aug 2023 16:56:58 +0300 From: Andy Shevchenko To: Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Mark Brown Subject: Re: [PATCH 18/25] ASoC: component: Add generic PCM copy ops Message-ID: References: <20230814115523.15279-1-tiwai@suse.de> <20230814115523.15279-19-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230814115523.15279-19-tiwai@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Message-ID-Hash: WVU2PMM3P664TXCCTF3JPD2RHLBFPMYO X-Message-ID-Hash: WVU2PMM3P664TXCCTF3JPD2RHLBFPMYO X-MailFrom: andriy.shevchenko@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Aug 14, 2023 at 01:55:16PM +0200, Takashi Iwai wrote: > For following the ALSA PCM core change, a new PCM copy ops is added > toe ASoC component framework: snd_soc_component_driver receives the > copy ops, and snd_soc_pcm_component_copy() helper is provided. > > This also fixes a long-standing potential bug where the ASoC driver > covers only copy_user PCM callback and misses the copy from kernel > pointers (such as OSS PCM layer), too. > > As of this patch, the old copy_user is still kept, but it'll be > dropped later after all drivers are converted. ... > + /* FIXME. it returns 1st copy now */ > + for_each_rtd_components(rtd, i, component) > + if (component->driver->copy) > + return soc_component_ret( > + component, This can be on the previous line. > + component->driver->copy( > + component, substream, channel, Ditto for the component parameter. > + pos, buf, bytes)); -- With Best Regards, Andy Shevchenko