From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54472E7AD57 for ; Tue, 3 Oct 2023 14:50:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D135784B; Tue, 3 Oct 2023 16:49:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D135784B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1696344637; bh=+Ho8OQ8KZ6j0Fkyejtlca4SZ/HaEVS5nu63V95Lo0rI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=qhIwmELzgkTVuhsA+xnx1gXXTWNN5QAM+4unUCGlGHmvGfU4VLtITyFmvTy1IzUut sPmxk0+GgnNfxHsKxoCcsfYz7g/TfH2vClId/jKiFSCQEB0HCOncsCYCh2xutOkxIu +gB7FupmNvY6lTYeH4fHxda2oxpSRI2avOKvtSDY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 43B0DF80557; Tue, 3 Oct 2023 16:49:38 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 9CF28F80130; Tue, 3 Oct 2023 16:49:37 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6740AF8047D; Tue, 3 Oct 2023 16:49:33 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7DD3EF801EB for ; Tue, 3 Oct 2023 16:49:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7DD3EF801EB Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=UMzh7wm2 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 66A066125E; Tue, 3 Oct 2023 14:49:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3FFFC433C9; Tue, 3 Oct 2023 14:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696344548; bh=+Ho8OQ8KZ6j0Fkyejtlca4SZ/HaEVS5nu63V95Lo0rI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UMzh7wm26I2LcyNKyLn7E8AH/ScySYJlF/+3NbK5vxyPNFU95Rc2ft3ztJx4TfCi3 JTITHfZlsgaWWp+E7ofLc22kb5lqz46HY/zVgcHQJhXgAc5A3UQn6FkIGX7k45fStM 0CeIj8c6YGqSd+nGTc+a6RnRjVJyzXBviZaLj/sHWKx90qbK5mijPPXj3DMIxE1jTP fkJQ6FBOqDuyrahb5K42N+1nbSEn801FFA2ZeyfJrXv6Z+801QVpo5VIk2HbmBLQrc DCLV+QfJO9SiGC1weVHeeQWfQ3N12ofo2sxJgJjZOE2GxWuwcl+pdY7h5TvYfYmKY9 SrYxhPhTjjphw== Date: Tue, 3 Oct 2023 10:49:06 -0400 From: Sasha Levin To: Richard Fitzgerald Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com Subject: Re: [PATCH 6.5] ASoC: cs35l56: Call pm_runtime_dont_use_autosuspend() Message-ID: References: <20231002125059.4091982-1-rf@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20231002125059.4091982-1-rf@opensource.cirrus.com> Message-ID-Hash: QWJD3T5VTSONY4VE2LS3PPXK47AZ2XRC X-Message-ID-Hash: QWJD3T5VTSONY4VE2LS3PPXK47AZ2XRC X-MailFrom: sashal@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Oct 02, 2023 at 01:50:59PM +0100, Richard Fitzgerald wrote: >commit ec03804552e9a723569e14d2512f36a8e70dc640 upstream > >Driver remove() must call pm_runtime_dont_use_autosuspend(). > >Drivers that call pm_runtime_use_autosuspend() must disable >it in driver remove(). Unfortunately until recently this was >only mentioned in 1 line in a 900+ line document so most >people hadn't noticed this. It has only recently been added >to the kerneldoc of pm_runtime_use_autosuspend(). > >Backport note: This is the same change as the upstream >commit but the cs35l56->base.dev argument in the upstream >code is cs35l56->dev in older releases. Queued up, thanks! -- Thanks, Sasha