From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 202F0CDB474 for ; Mon, 16 Oct 2023 11:22:16 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1037C850; Mon, 16 Oct 2023 13:21:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1037C850 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1697455334; bh=q+iGd/CB7mSwhLm751mIg/egIdSJ1LHlB98uwSQYkuk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ghbW0k1Su8q6yAX/+nW40T5VA4kV6948HQmrIMUXxLnh3aSxXoGGal03TShHnRarn 6emc/rmi/LhEumEpLcSJdL0l7oNCMS1AgOoH7jPvwSrjt2cP3cMr5HzuGG4l2NR1P8 SjdI0/RX+CD46PZDMm8RSU5FKeVAeuVNALecM9Ao= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 963A4F80553; Mon, 16 Oct 2023 13:20:54 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 6FB16F8025F; Mon, 16 Oct 2023 13:20:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4CC0CF8025F; Mon, 16 Oct 2023 13:20:48 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B0F7CF80236 for ; Mon, 16 Oct 2023 13:20:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B0F7CF80236 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=p2E/Lkby Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AAB3160C84; Mon, 16 Oct 2023 11:20:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC72DC433C8; Mon, 16 Oct 2023 11:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697455236; bh=q+iGd/CB7mSwhLm751mIg/egIdSJ1LHlB98uwSQYkuk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p2E/LkbyJ2VLzzGVpibk0z1VRTOc7NGRMFqw2aO48OpCL10+XTOjpwF5+zq9enCiG Wtkn9/4JDjkJLTbZdPPM2nBu13E2aAVJMY+ybflPXtHC7OXmE0LY17MfjFejAXj8gb 9cFzLHGRfoKMAzZ49QVlhAmCObiD9YEhp9cCpQXlZ5xeOKQMs6lu9q6ejjJL8NnFzj Brs8urcoBZ/eBkFh/O7C5ljjG3FTK8jrjMxbknpOGpG+sMmDYL+I9xtMngl1nmePs3 x+ztK4s2hkVAYP12y/VPHIam4cUhaFC7xTTRej9BfvOcZV3zsAhfFTPWGAREJ+ZDY0 vb1y1Dysk7Wfw== Date: Mon, 16 Oct 2023 16:50:32 +0530 From: Vinod Koul To: Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= Cc: Cezary Rojewski , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , alsa-devel@alsa-project.org Subject: Re: [PATCH] soundwire: Use snd_soc_substream_to_rtd() to obtain rtd Message-ID: References: <20230929105546.774332-1-amadeuszx.slawinski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230929105546.774332-1-amadeuszx.slawinski@linux.intel.com> Message-ID-Hash: U3NJHEEPBJCQ4RXFM55XD5JJNA2FUBJA X-Message-ID-Hash: U3NJHEEPBJCQ4RXFM55XD5JJNA2FUBJA X-MailFrom: vkoul@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 29-09-23, 12:55, Amadeusz Sławiński wrote: > From: Cezary Rojewski > > Utilize the helper function instead of casting from ->private_data > directly. > > Signed-off-by: Cezary Rojewski > Signed-off-by: Amadeusz Sławiński > --- > drivers/soundwire/stream.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c > index 69719b335bcb..652aae4e221d 100644 > --- a/drivers/soundwire/stream.c > +++ b/drivers/soundwire/stream.c > @@ -1717,7 +1717,7 @@ EXPORT_SYMBOL(sdw_deprepare_stream); > static int set_stream(struct snd_pcm_substream *substream, > struct sdw_stream_runtime *sdw_stream) > { > - struct snd_soc_pcm_runtime *rtd = substream->private_data; > + struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream); This does not exist for me, so I guess you can resend it after next cycle when this appears in rc1 -- ~Vinod