From: Vinod Koul <vkoul@kernel.org>
To: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
Cc: Bard Liao <yung-chuan.liao@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] soundwire: amd: drop bus freq calculation and set 'max_clk_freq'
Date: Sat, 2 Dec 2023 11:42:17 +0530 [thread overview]
Message-ID: <ZWrKwU90SLFtMMRO@matsya> (raw)
In-Reply-To: <30e6b8d3-6369-4c23-a4fa-f70cc01acd7e@amd.com>
On 01-12-23, 11:16, Mukunda,Vijendar wrote:
> On 29/11/23 18:34, Vinod Koul wrote:
> > max_dr_freq and curr_dr_freq is calculated and set in
> > sdw_bus_master_add(). Setting in the driver is reduanant, so drop that.
> > Set max_clk_freq instead.
> LGTM
Right way would be add a proper tag like
Reviewed-by: Foo bar <foo@bar.com>
or better to test the patch and update with
Tested-by: Foo bar <foo@bar.com> #on xyz target
--
~Vinod
next prev parent reply other threads:[~2023-12-02 6:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 13:04 [PATCH] soundwire: amd: drop bus freq calculation and set 'max_clk_freq' Vinod Koul
2023-12-01 5:46 ` Mukunda,Vijendar
2023-12-02 6:12 ` Vinod Koul [this message]
2023-12-02 6:16 ` Mukunda,Vijendar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWrKwU90SLFtMMRO@matsya \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vijendar.mukunda@amd.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox