From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: broonie@kernel.org, tiwai@suse.de, 13916275206@139.com,
13564923607@139.com, alsa-devel@alsa-project.org,
baojun.xu@ti.com
Subject: Re: [PATCH v1] ALSA: hda/tas2781: Create a common header for both spi and i2c tas2781 hda driver
Date: Tue, 8 Apr 2025 12:43:19 +0300 [thread overview]
Message-ID: <Z_Tvt1VsyBw8dS8m@smile.fi.intel.com> (raw)
In-Reply-To: <20250408024522.1338-1-shenghao-ding@ti.com>
On Tue, Apr 08, 2025 at 10:45:22AM +0800, Shenghao Ding wrote:
> Move the common macro definition of kcontrols into a common header.
Makes sense.
...
> +++ b/sound/pci/hda/tas2781_hda.h
> +#ifndef __TAS2781_HDA_H__
> +#define __TAS2781_HDA_H__
It is better to follow IWYU principle, i.e. this header uses the following:
+ sound/asound.h
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-04-08 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 2:45 [PATCH v1] ALSA: hda/tas2781: Create a common header for both spi and i2c tas2781 hda driver Shenghao Ding
2025-04-08 9:43 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_Tvt1VsyBw8dS8m@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13564923607@139.com \
--cc=13916275206@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox