From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41548C47077 for ; Tue, 16 Jan 2024 13:11:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6761F201; Tue, 16 Jan 2024 14:10:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6761F201 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1705410669; bh=i4dry6M6WDVUsf16531MxNHkF/ieE3KAF4x/oxtezNo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=mjjoOdbJ+WFMqr0B20H8AW3EjDkKLMfuAAXItQ1XduN+TsHZVoQvhLkKMTN7pAaQb /XbPMVAZpne4Hf589mSIOBum1srXMdmGatLAv+cpANpIW0lbSPeVVd4dvFnzRTi0/u LC5w8JLW+vfkdSVTrD9Sr/NzUq5KeQPPKBiy3g8M= Received: by alsa1.perex.cz (Postfix, from userid 50401) id BCD0BF8058C; Tue, 16 Jan 2024 14:10:35 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id E4CACF80587; Tue, 16 Jan 2024 14:10:34 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 65B79F801F5; Tue, 16 Jan 2024 14:10:30 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 71DFDF80074 for ; Tue, 16 Jan 2024 14:10:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 71DFDF80074 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=oDhj0ufm Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 6FF89B80DCD; Tue, 16 Jan 2024 13:10:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9C9BC433C7; Tue, 16 Jan 2024 13:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705410616; bh=i4dry6M6WDVUsf16531MxNHkF/ieE3KAF4x/oxtezNo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oDhj0ufmBZ5rhO3OPZzmZDuzn9J90cGHPEF3adOa7IMzTRLXaZV8Khdd0rmAMF7uV xHL3+MkX22jLdE1SRP3SEZdWUmdK/vaubuGSljwLzIZwx851xPFEnxuYQxDMZHmeN4 xQFtajGQnZNKQJ0qHzO1I+PRphGmAcAkMhVha4UnfFp2w9QL9TuWOJGylInnhAnxmH RTiGLN1xKE/9HhRETXXIV7h8u0Rw3e3e7IdFE6Aex92sBHh1GepwBotSwxhVGrNvCh Um+7ZN8Ltee3ql6l11b3vrvEY8inpgpGSS/NksYL6I5isd9hQ+MqSqW0149552QpOP djgnIp4WMSTJA== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rPjCt-00065Y-1B; Tue, 16 Jan 2024 14:10:20 +0100 Date: Tue, 16 Jan 2024 14:10:19 +0100 From: Johan Hovold To: Srinivas Kandagatla Cc: Johan Hovold , Mark Brown , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/7] ASoC: codecs: lpass-wsa-macro: fix compander volume hack Message-ID: References: <20240116093903.19403-1-johan+linaro@kernel.org> <20240116093903.19403-3-johan+linaro@kernel.org> <8bb1cad6-6a85-444a-b881-c03ab0051009@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8bb1cad6-6a85-444a-b881-c03ab0051009@linaro.org> Message-ID-Hash: ITOAVINTGRLCOIDGALI2JXOPKT6X46K6 X-Message-ID-Hash: ITOAVINTGRLCOIDGALI2JXOPKT6X46K6 X-MailFrom: johan@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Jan 16, 2024 at 11:10:21AM +0000, Srinivas Kandagatla wrote: > Thanks Johan for this patch, > > On 16/01/2024 09:38, Johan Hovold wrote: > > The LPASS WSA macro codec driver is updating the digital gain settings > > behind the back of user space on DAPM events if companding has been > > enabled. > > > > As compander control is exported to user space, this can result in the > > digital gain setting being incremented (or decremented) every time the > > sound server is started and the codec suspended depending on what the > > UCM configuration looks like. > > > > Soon enough playback will become distorted (or too quiet). > > > > This is specifically a problem on the Lenovo ThinkPad X13s as this > > bypasses the limit for the digital gain setting that has been set by the > > machine driver. > > > > Fix this by simply dropping the compander gain hack. If someone cares > > about modelling the impact of the compander setting this can possibly be > > done by exporting it as a volume control later. > > > This is not a hack, wsa codec requires gain to be programmed after the > clk is enabled for that particular interpolator. Ok, but then it's also broken as, as I mentioned off-list, these registers are cached so unless companding is enabled, the write on enable will have no effect. > However I agree with you on programming the gain that is different to > what user set it. > > This is because of unimplemented or half baked implementation of half-db > feature of gain control in this codec. > > We can clean that half baked implementation for now and still continue > to program the gain values after the clks are enabled. > > lets remove spkr_gain_offset and associated code paths in this codec, > which should fix the issue that you have reported and still do the right > thing of programming gain after clks are enabled. Removing the offset which can alter the gain, will cause both of these writes to become no-ops as the registers are cached (e.g. just as for the follow-on codec cleanups). So then we might as well just remove this too. How is the half-dB feature supposed to work? And are you sure that you need to reprogram the gain value after enabling the clock? Everything seems to work without doing so. Johan