From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C269C47DB7 for ; Fri, 19 Jan 2024 08:00:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 72FC71F7; Fri, 19 Jan 2024 09:00:39 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 72FC71F7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1705651249; bh=RvV+1/JImv/LsRuTBtSvKboMDVj2C5IRu1Y90h46cMw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=j0MRvREkYuolDR3HeLRR4fF/VZ0KyQENH2otSjj1hM7gemBPFm6jvEq7wL+4PF1IN 0Hr7T6VKzsUroQcq+FaQIfwVgYU+M/5lQNb5owkw3lc6GvhDTKd8eY7UJusO4YiuRk pQpfizUOxOiy9sdj08jkACL6qMZMAtoJ0y3/Wfoo= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 10E98F8057C; Fri, 19 Jan 2024 09:00:20 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 74272F80568; Fri, 19 Jan 2024 09:00:19 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 03A30F801F5; Fri, 19 Jan 2024 09:00:13 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2E201F80074 for ; Fri, 19 Jan 2024 09:00:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2E201F80074 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=cs09mdNN Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 93F8061083; Fri, 19 Jan 2024 08:00:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 322C1C43390; Fri, 19 Jan 2024 08:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705651207; bh=RvV+1/JImv/LsRuTBtSvKboMDVj2C5IRu1Y90h46cMw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cs09mdNNXn/aACNvQqz5ULreJfjwPVRxn8+H6D39eaWB57CeeCyQAf3qFkJ0r0Co4 gm/i6ZljCOGciBqfUaZas4CEgLSUgKNaBhTdX4h5xAAaWsWA2rmDjmQNCFdhr8iMwf aWklHr9uTSG/2DrbxsCHkqH38+bFyLHicrWVU/wIrSGqMKQSCSdB2WvlEqmFl9Hrk3 o+tN/PTFdsXeV4PLrVtGf23hli2nVfpjAbvNHrlUgYS3J5OmxmlKnMXP2A15fwAQHc GCYzEIpv+Ol/iexkRvigJCVTZSKBBo32ifJM3DmayVuccwcQONNO+YODHiDCeKGzvF 5aiJb63saaCqg== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rQjnT-0004Yp-2Z; Fri, 19 Jan 2024 09:00:15 +0100 Date: Fri, 19 Jan 2024 09:00:15 +0100 From: Johan Hovold To: Srinivas Kandagatla Cc: Johan Hovold , Mark Brown , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 2/5] ASoC: codecs: wsa883x: lower default PA gain Message-ID: References: <20240118165811.13672-1-johan+linaro@kernel.org> <20240118165811.13672-3-johan+linaro@kernel.org> <63e000c7-deae-44df-8d82-a74ffe303e9a@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <63e000c7-deae-44df-8d82-a74ffe303e9a@linaro.org> Message-ID-Hash: HGGHRYUIXQSDPPKGL2AC76QKWENKHDYV X-Message-ID-Hash: HGGHRYUIXQSDPPKGL2AC76QKWENKHDYV X-MailFrom: johan@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, Jan 19, 2024 at 07:15:33AM +0000, Srinivas Kandagatla wrote: > > > On 18/01/2024 16:58, Johan Hovold wrote: > > The default PA gain is set to a pretty high level of 15 dB. Initialise > > the register to the minimum -3 dB level instead. > > > > This is specifically needed to allow machine drivers to use the lowest > > level as a volume limit. > > > > Cc: stable@vger.kernel.org # 6.5 > > Signed-off-by: Johan Hovold > > --- > > sound/soc/codecs/wsa883x.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c > > index 32983ca9afba..8942c88dee09 100644 > > --- a/sound/soc/codecs/wsa883x.c > > +++ b/sound/soc/codecs/wsa883x.c > > @@ -722,7 +722,7 @@ static struct reg_default wsa883x_defaults[] = { > > { WSA883X_WAVG_PER_6_7, 0x88 }, > > { WSA883X_WAVG_STA, 0x00 }, > > { WSA883X_DRE_CTL_0, 0x70 }, > > - { WSA883X_DRE_CTL_1, 0x08 }, > > this is hw default value. Indeed. This was a last minute change when I noticed I could actually set the lowest limit in the machine driver after I offset it, but then the reset value was never updated. Didn't think this through. > > + { WSA883X_DRE_CTL_1, 0x1e }, > > { WSA883X_DRE_IDLE_DET_CTL, 0x1F }, > > { WSA883X_CLSH_CTL_0, 0x37 }, > > { WSA883X_CLSH_CTL_1, 0x81 }, Johan