From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5363CD1294 for ; Wed, 3 Apr 2024 10:05:48 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7D5EF2CD0; Wed, 3 Apr 2024 12:05:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7D5EF2CD0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1712138745; bh=Y7WN2tYAYpmCgOP1gQPKV9jeKqkz0Te+qM3j90UOY1g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=jWnEGM7zSBPCjt2g++A8R+DlV7+Inh431hwMtmJlLuDO0VFzcCY3/HPb99klVCtb/ dvrU17EaHbspYL3AoIMyPZmYB4RIBcT41N/ll4JbV6agHMbr7DzjBO46uQCZZxYN3Z cvjHzU+l9ZWbsyaPg9vSLcVZ6tbAxzRUpDnSC6p0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 582F2F8059F; Wed, 3 Apr 2024 12:05:13 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id AF5AEF80238; Wed, 3 Apr 2024 12:05:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4C399F8020D; Wed, 3 Apr 2024 12:05:08 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C473AF8015B for ; Wed, 3 Apr 2024 12:05:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C473AF8015B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=b+C0f+A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712138703; x=1743674703; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Y7WN2tYAYpmCgOP1gQPKV9jeKqkz0Te+qM3j90UOY1g=; b=b+C0f+A1ZXQOh215Ooj8tDSO68dnO3MAvOEz068IPeF6JrsSayjAOcOD 1E/wVCyp21e1VZPM3zTKClM/mWhwY63SnDzhl0oPEFG6QLdBYVPK4d+kE XPLgsZLBOur23Z1tq4j6sifxXitL9S51qJyXz7lqZkg+//8czIg9U8ob8 SH+5NglPIv5MzBtvZe1VzeXaQiqksTNJiMpIJA2Ud0iksZSBltn/pgu0R Gp6e6ZK9Jsfl7VNRxwgj9763g523DiUFhH7qPFKrQfLHwDa/2DDps03uO c0TMCH56FOeG9jCEQ4a+VNPydfnvt463qxvTfVsgrjwsFklGKKHlXA3Xg g==; X-CSE-ConnectionGUID: Y7Ot4MqTQsOaCz/lY4be2Q== X-CSE-MsgGUID: CdYtZ/ZXRiW/Yj6XDd7iMQ== X-IronPort-AV: E=McAfee;i="6600,9927,11032"; a="7485609" X-IronPort-AV: E=Sophos;i="6.07,177,1708416000"; d="scan'208";a="7485609" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2024 03:04:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11032"; a="915177205" X-IronPort-AV: E=Sophos;i="6.07,177,1708416000"; d="scan'208";a="915177205" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2024 03:04:53 -0700 Received: from andy by smile with local (Exim 4.97) (envelope-from ) id 1rrxUA-000000015H8-1gdE; Wed, 03 Apr 2024 13:04:50 +0300 Date: Wed, 3 Apr 2024 13:04:50 +0300 From: Andy Shevchenko To: Shenghao Ding Cc: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, pierre-louis.bossart@linux.intel.com, 13916275206@139.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com, bard.liao@intel.com, yung-chuan.liao@linux.intel.com, kevin-lu@ti.com, tiwai@suse.de, baojun.xu@ti.com, soyer@irl.hu, Baojun.Xu@fpt.com, navada@ti.com, v-po@ti.com Subject: Re: [PATCH v1] ALSA: hda/tas2781: correct the register for pow calibrated data Message-ID: References: <20240402231300.362-1-shenghao-ding@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240402231300.362-1-shenghao-ding@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Message-ID-Hash: N765PVMEYQMMK6XNHXFATFLH23V7BUN4 X-Message-ID-Hash: N765PVMEYQMMK6XNHXFATFLH23V7BUN4 X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 07:12:59AM +0800, Shenghao Ding wrote: > fixed tas2781 calibrated data - pow was written into a wrong register. fixed --> Fix Fixes tag? > Signed-off-by: Shenghao Ding ... > + 0x17, 0x18, 0x18, 0x13, 0x18 > + 0x74, 0x0c, 0x14, 0x70, 0x7c While at it, can you add a trailing comma? It will help in case of extending this in the future. -- With Best Regards, Andy Shevchenko