From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA2D8CD11DD for ; Tue, 26 Mar 2024 15:01:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3C6CD23D1; Tue, 26 Mar 2024 16:00:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3C6CD23D1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1711465269; bh=euufMSB4SVE5RBXsdwnHwJCF8Qu8BkG8kahi1cBb2O4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=jKBPlWOoFREHE20XuIm3yKf97qQZwqgKhYptbyJfqVvrUqYT/POIIBuWeJWB8WTkF FJpSActAwUo0gDJOiL+7VcIjPs9NDmgNCuHnh3rc20dGd1iRGzeUDbiOUWDadn0Bci 7UHNh1hMQmbFn6gEDOMdYjzl5VzVWa0N68ky0LmU= Received: by alsa1.perex.cz (Postfix, from userid 50401) id E5BA1F80236; Tue, 26 Mar 2024 16:00:37 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 555F3F805A9; Tue, 26 Mar 2024 16:00:36 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1E38CF8025F; Tue, 26 Mar 2024 15:59:15 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DE2A9F801D5 for ; Tue, 26 Mar 2024 15:58:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DE2A9F801D5 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Ab+hFY/I DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711465140; x=1743001140; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=euufMSB4SVE5RBXsdwnHwJCF8Qu8BkG8kahi1cBb2O4=; b=Ab+hFY/IK8wRnKRsT0IkHFvum0FrRxC9JD63q9ucWi6+McilMmptgwdh lKVKyOOPIRetWxL13/3+j4MiknFsPjEOkz1tZ05j6fHNwx/jg6NZLiD6c iAF6Po2TEIoZRnFjOticv928tEcKxqQvpc7DmVTwkl5o5i4h0hxW+eDwm oKQ8e/GIFwDUPInmG6yqOLwKoyWh7AlbuJhOjEx59adPZVXrigWswpyQs 6iOiUf+i3LyK5WOj+7fVrhabxRRcy6aeuGSL/ZnfEBKt49PNXcBlJIjh6 cTWTqUS9hJKDzj2Nz2kKZYuDhMUXdYgm2rEvgELBcdGQuIZ2C0FU/NVWu g==; X-CSE-ConnectionGUID: 4U6T5JAtT+iqVtP6gTXjSg== X-CSE-MsgGUID: Da+7CgAQSpyhqALyZjSA9w== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="29000283" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="29000283" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 07:58:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="914882629" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="914882629" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 07:58:50 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rp8GF-0000000GKhL-46Jt; Tue, 26 Mar 2024 16:58:47 +0200 Date: Tue, 26 Mar 2024 16:58:47 +0200 From: Andy Shevchenko To: Baojun Xu Cc: tiwai@suse.de, robh+dt@kernel.org, lgirdwood@gmail.com, perex@perex.cz, pierre-louis.bossart@linux.intel.com, kevin-lu@ti.com, 13916275206@139.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com, yung-chuan.liao@linux.intel.com, broonie@kernel.org, soyer@irl.hu Subject: Re: [PATCH v1 1/8] ALSA: hda/tas2781: Add tas2781 SPI-based driver Message-ID: References: <20240326010905.2147-1-baojun.xu@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240326010905.2147-1-baojun.xu@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Message-ID-Hash: TDUAKPMCZ7FUL64MC3VPU6ZHYF7HTPYS X-Message-ID-Hash: TDUAKPMCZ7FUL64MC3VPU6ZHYF7HTPYS X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Mar 26, 2024 at 09:08:58AM +0800, Baojun Xu wrote: > Add TXNW2781 support in smi. What is 'smi'? Can you make message less cryptic, please? Also explain why it should be in that list in scan.c. Code wise LGTM, so with commit message fixed, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko