From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB44BC10F16 for ; Tue, 30 Apr 2024 13:45:46 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6AED8B6A; Tue, 30 Apr 2024 15:45:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6AED8B6A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1714484744; bh=2UDOlMajI8DsE4OHRS3aVKxvrNd40hazdzrDjFIsdXE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=lN4UEI3ViM3VWkcQTaZp+dhcT8j66W/djuVCv+rr6MtkOALGes+XIAmaAqLr9b3xU FnOjxv0mH7biasCa7FZTpQMoIWqDcqxNEcS9O0rFGRoLHl4yIxDgZYP3ytAPsCe75c hgEZI3BDgRrzH+E0BDn36PV6FRV/zjajwDWua1UI= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 73344F80605; Tue, 30 Apr 2024 15:44:44 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 1A713F805F9; Tue, 30 Apr 2024 15:44:44 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 139DAF80266; Tue, 30 Apr 2024 15:44:35 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 59FC8F8003A for ; Tue, 30 Apr 2024 15:44:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 59FC8F8003A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=hizNiqrS DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714484668; x=1746020668; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=2UDOlMajI8DsE4OHRS3aVKxvrNd40hazdzrDjFIsdXE=; b=hizNiqrSAr6urB2Wap6NPUTk7i8GLFaz40S2RT/pr9kuA3LWNCnMW6mH tUjAz+GAwmc3uZx4wMvidHa1JHVn8dFBxmY+LsO+9I9wSDSyAIe4aeTfk QghhuoXjS6F5w33+JePbOerFv4rP+h8Phkd8dtH4FWPp00F/SGwOKNlKn hzXthn9DdBZICb6lOuH5JrnfduKP9+2rMP5AHJifYhbdthhD6W8tWXwL+ rg7o3HSeQ7pb3bBVbjycRRT6tjaDeVlgOqCRdsQw6l0KT3wT/KV2IhUDi BKwb+xkFMXJbmsB/BzaY+tZCefsamCQDozadTb7y8dp2RET5DKY3/liaS g==; X-CSE-ConnectionGUID: NWV5thHlSHicKCACVQG6gg== X-CSE-MsgGUID: NlZfsLF1TrWYPN/7LlY2ng== X-IronPort-AV: E=McAfee;i="6600,9927,11060"; a="10729734" X-IronPort-AV: E=Sophos;i="6.07,242,1708416000"; d="scan'208";a="10729734" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2024 06:44:22 -0700 X-CSE-ConnectionGUID: mgmnKKShQMG9iua9PfZIfQ== X-CSE-MsgGUID: spqYxkyUQHScc8boV0HzRQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,242,1708416000"; d="scan'208";a="26964803" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2024 06:44:18 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1s1nmI-00000002g1m-0sDM; Tue, 30 Apr 2024 16:44:14 +0300 Date: Tue, 30 Apr 2024 16:44:13 +0300 From: Andy Shevchenko To: Baojun Xu Cc: tiwai@suse.de, robh+dt@kernel.org, lgirdwood@gmail.com, perex@perex.cz, pierre-louis.bossart@linux.intel.com, kevin-lu@ti.com, shenghao-ding@ti.com, navada@ti.com, 13916275206@139.com, v-po@ti.com, niranjan.hy@ti.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com, yung-chuan.liao@linux.intel.com, broonie@kernel.org, soyer@irl.hu Subject: Re: [PATCH v4 1/3] ALSA: hda/tas2781: Add tas2781 hda driver based on SPI Message-ID: References: <20240430072544.1877-1-baojun.xu@ti.com> <20240430072544.1877-2-baojun.xu@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240430072544.1877-2-baojun.xu@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Message-ID-Hash: 4HMOMV2JIQDZSXW66P4JNZYHKIZBUYLS X-Message-ID-Hash: 4HMOMV2JIQDZSXW66P4JNZYHKIZBUYLS X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Apr 30, 2024 at 03:25:42PM +0800, Baojun Xu wrote: > Integrate tas2781 hda spi driver configs for HP (Varcolac). > Every tas2781 SPI node was added by serial-multi-instantie.c as a SPI device. > The code support Realtek as the primary codec. ... > + {"TIAS2781", }, Is this for real? I mean you really abused ACPI specifications to get this into the real products on the market?! If so, never do this again. _This_ one is non-conforming abuse of ACPI specification and has not to be here at all. But, if the above is the case, provide the models of the devices and the excerpt of the DSDT where this broken ID happen, also add a big comment explaining how comes this happened and that you promise to never happen this again. ... > + { "TIAS2781", (unsigned long)&tas2781_hda }, Ditto. ... > +config SND_HDA_SCODEC_TAS2781_SPI > + tristate "Build TAS2781 HD-audio side codec support for SPI Bus" > + depends on SPI_MASTER > + depends on ACPI No compile test? > + depends on EFI > + depends on SND_SOC > + select CRC32_SARWATE > + help > + Say Y or M here to include TAS2781 SPI HD-audio side codec support > + in snd-hda-intel driver, such as ALC287. -- With Best Regards, Andy Shevchenko