Re: [PATCH alsa-ucm-conf 2/2] sof-soundwire: Add support for cs42l43/cs35l56 bridge configuration

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Mon, Jun 24, 2024 at 02:41:45PM +0200, Jaroslav Kysela wrote:
> On 24. 06. 24 14:20, Charles Keepax wrote:
> > The cs42l43 has both a SPI master and an I2S interface, in some
> > configurations 2 cs35l56 amplifiers are connected to these to provide
> > bass speakers whilst the cs42l43's internal speaker drivers are used for
> > the tweeters. Add UCM configuration for this type of system.
> > 
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> >   ucm2/sof-soundwire/cs35l56-bridge.conf | 61 ++++++++++++++++++++++++++
> >   ucm2/sof-soundwire/sof-soundwire.conf  |  2 +-
> >   2 files changed, 62 insertions(+), 1 deletion(-)
> >   create mode 100644 ucm2/sof-soundwire/cs35l56-bridge.conf
> > 
> > diff --git a/ucm2/sof-soundwire/cs35l56-bridge.conf b/ucm2/sof-soundwire/cs35l56-bridge.conf
> > new file mode 100644
> > index 0000000..6fafc80
> > --- /dev/null
> > +++ b/ucm2/sof-soundwire/cs35l56-bridge.conf
> > @@ -0,0 +1,61 @@
> > +# Use case Configuration for sof-soundwire card
> > +
> > +LibraryConfig.remap.Config {
> > +	ctl.default.map {
> > +		"name='cs42l43 Bridge Switch'" {
> > +			"name='AMPL Speaker Switch'".vindex.0 0
> > +			"name='AMPR Speaker Switch'".vindex.1 0
> 
> The logical/abstract names should not contains any chip or specific hardware
> identification. Just use "Speaker Switch" and "Speaker Volume" to not
> confuse users.
> 

Can do.

> For my information - "AMPL/R Speaker Volume" is digital or analog volume control?
> 

It's a digital volume, although I guess technically its
controlled by firmware in this case, so in the future it could
be updated to actually control the analog volume, but I am not
aware of any plans to do so.

Thanks,
Charles