From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
pierre-louis.bossart@linux.intel.com, 13916275206@139.com,
zhourui@huaqin.com, alsa-devel@alsa-project.org,
i-salazar@ti.com, liam.r.girdwood@intel.com, jaden-yue@ti.com,
yung-chuan.liao@linux.intel.com, dipa@ti.com, yuhsuan@google.com,
henry.lo@ti.com, tiwai@suse.de, baojun.xu@ti.com,
Baojun.Xu@fpt.com, judyhsiao@google.com, navada@ti.com,
cujomalainey@google.com, aanya@ti.com, nayeem.mahmud@ti.com,
savyasanchi.shukla@netradyne.com, flaviopr@microsoft.com,
jesse-ji@ti.com, darren.ye@mediatek.com, antheas.dk@gmail.com,
Jerry2.Huang@lcfuturecenter.com, jim.shil@goertek.com
Subject: Re: [PATCH v1] ASoC: tas2781: mark const variables tas2563_dvc_table as __maybe_unused
Date: Thu, 22 Aug 2024 16:36:52 +0300 [thread overview]
Message-ID: <Zsc-9PVnh8GpPrrP@smile.fi.intel.com> (raw)
In-Reply-To: <20240822063205.662-1-shenghao-ding@ti.com>
On Thu, Aug 22, 2024 at 02:32:02PM +0800, Shenghao Ding wrote:
> In case of tas2781, tas2563_dvc_table will be unused,
> so mark it as __maybe_unused.
...
> /* pow(10, db/20) * pow(2,30) */
> -static const unsigned char tas2563_dvc_table[][4] = {
> +static const __maybe_unused unsigned char tas2563_dvc_table[][4] = {
> { 0X00, 0X00, 0X00, 0X00 }, /* -121.5db */
> { 0X00, 0X00, 0X03, 0XBC }, /* -121.0db */
> { 0X00, 0X00, 0X03, 0XF5 }, /* -120.5db */
As far as I can see in the latest Linux Next the above mentioned table is used
solely in sound/soc/codecs/tas2781-i2c.c. Why not moving it to the C file
instead?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-22 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 6:32 [PATCH v1] ASoC: tas2781: mark const variables tas2563_dvc_table as __maybe_unused Shenghao Ding
2024-08-22 13:36 ` Andy Shevchenko [this message]
2024-08-23 2:24 ` [EXTERNAL] " Ding, Shenghao
2024-08-23 13:34 ` Andy Shevchenko
2024-08-24 6:33 ` Ding, Shenghao
2024-08-26 10:02 ` Andy Shevchenko
2024-08-22 16:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zsc-9PVnh8GpPrrP@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13916275206@139.com \
--cc=Baojun.Xu@fpt.com \
--cc=Jerry2.Huang@lcfuturecenter.com \
--cc=aanya@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=antheas.dk@gmail.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=cujomalainey@google.com \
--cc=darren.ye@mediatek.com \
--cc=dipa@ti.com \
--cc=flaviopr@microsoft.com \
--cc=henry.lo@ti.com \
--cc=i-salazar@ti.com \
--cc=jaden-yue@ti.com \
--cc=jesse-ji@ti.com \
--cc=jim.shil@goertek.com \
--cc=judyhsiao@google.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=navada@ti.com \
--cc=nayeem.mahmud@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=savyasanchi.shukla@netradyne.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
--cc=yuhsuan@google.com \
--cc=yung-chuan.liao@linux.intel.com \
--cc=zhourui@huaqin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox