From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Maciej Strozek <mstrozek@opensource.cirrus.com>
Cc: <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH alsa-ucm-conf 1/2] sof-soundwire: Change mapped control names to make them unique
Date: Tue, 1 Oct 2024 11:21:15 +0100 [thread overview]
Message-ID: <ZvvNGy2P9/PkMrY9@opensource.cirrus.com> (raw)
In-Reply-To: <20240930134118.2640509-1-mstrozek@opensource.cirrus.com>
On Mon, Sep 30, 2024 at 02:41:17PM +0100, Maciej Strozek wrote:
> Both 'Speaker Digital' and 'cs42l43 PDM2' names were found as substrings in
> other alsa controls, confusing the MixerElems paths. Make them unique to avoid
> errors for hardware mutes. Also add 'Capture' string into microphone controls
> to make them work properly.
>
> Fixes: e87dde51d689 ("sof-soundwire: Add basic support for cs42l43")
> Fixes: e4277a204cd6 ("sof-soundwire: Add support for cs42l43/cs35l56 bridge configuration")
> Signed-off-by: Maciej Strozek <mstrozek@opensource.cirrus.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2024-10-01 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 13:41 [PATCH alsa-ucm-conf 1/2] sof-soundwire: Change mapped control names to make them unique Maciej Strozek
2024-09-30 13:41 ` [PATCH alsa-ucm-conf 2/2] sof-soundwire: Add sequence for controlling Mic Mute LED Maciej Strozek
2024-10-01 10:21 ` Charles Keepax
2024-10-01 10:21 ` Charles Keepax [this message]
2024-10-01 10:38 ` [PATCH alsa-ucm-conf 1/2] sof-soundwire: Change mapped control names to make them unique Jaroslav Kysela
2024-10-01 10:51 ` Maciej Strozek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvvNGy2P9/PkMrY9@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=mstrozek@opensource.cirrus.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox