From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70AFFC4338F for ; Fri, 30 Jul 2021 11:07:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F054361008 for ; Fri, 30 Jul 2021 11:07:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F054361008 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8B1021924; Fri, 30 Jul 2021 13:06:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8B1021924 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1627643267; bh=3+is6jQgrYnGpvKEQAykwQub24LD1KngHinBeYLmUD8=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=QJcpGJ07SKAqIkcP/oHgqR4hRj8PnOADOl3mPZIFHT9rJTVnpjTFP0K/Q620oPbnm viPmQo9SlckwBFeIHnqXnaHtJoV0rKd50mjMl3LuM3kvExCg4Sg4vVwlYwC+asRSG8 s7CbcgMthqT37HTuOcg0VXJXW/P12ZTnvzKuEOLM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 268C8F80212; Fri, 30 Jul 2021 13:06:57 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id ACECDF80253; Fri, 30 Jul 2021 13:06:52 +0200 (CEST) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3ADBDF8019B for ; Fri, 30 Jul 2021 13:06:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3ADBDF8019B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EIE2baSC" Received: by mail-wr1-x431.google.com with SMTP id q3so10880194wrx.0 for ; Fri, 30 Jul 2021 04:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7cN7mCAd1PgSaOiwUYeJf080GlnYfimOBZ14rsMi0+0=; b=EIE2baSCXqVT4dVgY1Gguj0uDW2UV88MV3gEfeX1XFWqHh0DznHHGFa58B4wRUEMYh deqJ+oTinvP62Ow2Dv3/AVHnn5K535NV4oBCy9AvGSjg8XETNasDy2r8iaHpxePS0OHF KFp/upiTubTFSIlYPo9o7BY87UbFZDzUjPEHaeDm6edcyDvnCj2sGZL261EonUmJ4i2Y tdCy21VeTSDuf/9Z1GK/8MRairCaptF1pzQnn4obYRll0xYstlM0FcXL65gDBQx3Um5a FxikgGBu3MQ0aD+ykNY/WF55YtUFHzLsNHv9xfmStoEld6AgNt16sfeHnzOfySGjWBMt /TrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7cN7mCAd1PgSaOiwUYeJf080GlnYfimOBZ14rsMi0+0=; b=tKlEq/H1LJeVBRsRW/C3veb5yvcc021TtCdKMcnSEXIevrjnsNuize2PBAjwnj0TKi +zaGzI2W6aHc2LbicJ5zy2tr2L0hGJzc2zqZ78x5t+Ywamz1FXdwSwYvPrA45502mmUz Lth8sI4n2DiSVMmhqQ4k8xfX+WvzppZXgPyZleYyuWCyZnRYhRWXsrnTyYWIw5p/Ljz2 cFoQtFeFoTdjFdcPglFpfCB/LN1vhVsB1ZRHP6KpqMlNy42D7VOIXDiWaFDMzaLYVJ2f JBb7hEK39b8ialiDPEqnh4op+lkmSfbTMILg2DrqTNYgeq66t1b4UhHFVH431QKjPmMK i6DA== X-Gm-Message-State: AOAM530ikLIVl3fVltFpvuia8+GOeUT1s76AcROn8g2Lj21kFsZ8h7xc ECv7OIIIpqwrharg9sP//kBCBA== X-Google-Smtp-Source: ABdhPJwJg9Ja1mRbrDoc3k6Xo2NEMjyjUAiTl4lgkbRru8uTrdydvtGvqnfvahOos5jVuAw9eXwYqQ== X-Received: by 2002:a05:6000:1d0:: with SMTP id t16mr2382907wrx.213.1627643207487; Fri, 30 Jul 2021 04:06:47 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id 6sm1486139wmi.3.2021.07.30.04.06.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jul 2021 04:06:46 -0700 (PDT) Subject: Re: [PATCH v2 04/16] ASoC: qcom: dt-bindings: add bindings Audio Processing manager To: Mark Brown References: <20210714153039.28373-1-srinivas.kandagatla@linaro.org> <20210714153039.28373-5-srinivas.kandagatla@linaro.org> <20210728173649.GA1290628@robh.at.kernel.org> <092018be-50ae-6dda-73cd-6c7eb002dc19@linaro.org> <20210729111338.GJ4670@sirena.org.uk> From: Srinivas Kandagatla Message-ID: Date: Fri, 30 Jul 2021 12:06:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210729111338.GJ4670@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Rob Herring , alsa-devel@alsa-project.org, bgoswami@codeaurora.org, devicetree@vger.kernel.org, tiwai@suse.de, lgirdwood@gmail.com, plai@codeaurora.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Thanks Mark for the review, On 29/07/2021 12:13, Mark Brown wrote: >>> This all looks fairly similar to the prior Qcom audio binding(s). It >>> would be nice to not see this all re-invented. >> AudioReach is a new DSP signal processing framework Which is different to >> its previous DSP firmware(aka Elite). >> It makes use of ASoC Topology to load audio graphs on to the DSP which is >> then managed by APM (Audio Processing Manager) service. >> So internals are not exactly same. >> From device tree side we might end up with similar layout, but there are >> some subtle differences like clocks are managed by q6prm service instead of >> q6afe service in old firmware, front-end pcm dais definitions come from ASoC >> topology. > The software we're running on the hardware shouldn't impact how the > hardware is described, it should be posible to switch DSP frameworks on > the same hardware - look at what Intel have done with SoF. I totally agree with you. There are two parts to the software running on the hardware, first is the hardware itself and second is the services that are running which control parts of hardware. Hardware device tree description across these new and old DSP framework are exactly same, However association between hardware and DSP service would change as per DSP framework services it exposes. Ex: clock controller would be associated with PRM(proxy resource manager) in AudioReach vs AFE (Audio Frontend Manager) in Elite, but the clocks and other hardware properties remain same across these. As exiting DT-bindings had both services and hardware description in same document which Is why I could not reuse it. I will try to split up the hardware parts and DSP services parts in the existing bindings so that we could reuse the hardware bindings across multiple dsp frameworks. It should also be possible to reuse some old code too in this process. --srini > >> Are you suggesting that we should reuse the old bindings (q6afe, q6asm) by >> add new compatible strings along with differences ?