From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>,
ALSA development <alsa-devel@alsa-project.org>
Subject: Re: [alsa-devel] [PATCH v2 1/2] ASoC: improve the DMI long card code in asoc-core
Date: Thu, 21 Nov 2019 09:14:15 -0600 [thread overview]
Message-ID: <a08eb3a2-49d4-5637-256f-ac8a1debc305@linux.intel.com> (raw)
In-Reply-To: <20191121121136.GB4071@sirena.org.uk>
On 11/21/19 6:11 AM, Mark Brown wrote:
> On Thu, Nov 21, 2019 at 01:02:38PM +0100, Jaroslav Kysela wrote:
>> Dne 21. 11. 19 v 12:51 Mark Brown napsal(a):
>>> On Wed, Nov 20, 2019 at 06:44:34PM +0100, Jaroslav Kysela wrote:
>
>>>> - /* make up dmi long name as: vendor.product.version.board */
>>>> + /* make up dmi long name as: vendor-product-version-board */
>
>>> I'm worried about this from an ABI point of view with people's UCM
>>> files. But perhaps I'm worrying about nothing?
>
>> this is just the C comment fix. The long name is already in
>> vendor-product-version-board - no dots as delimiters (but does are allowed
>> in the fields like version strings). This code improvement does not change
>> the format of the generated long name string from the DMI information.
>
> Ah, it looked from my initial scan like it was being changed as a result
> of the factoring out of the append code.
I had the same reaction on v1, it's just cleaning up a bad comment indeed.
This looks good to me, especially the removal of redundant parts, so for
the patch 1..2
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-21 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 17:44 [alsa-devel] [PATCH v2 1/2] ASoC: improve the DMI long card code in asoc-core Jaroslav Kysela
2019-11-20 17:44 ` [alsa-devel] [PATCH v2 2/2] ASoC: DMI long name - avoid to add board name if matches with product name Jaroslav Kysela
2019-11-22 19:55 ` [alsa-devel] Applied "ASoC: DMI long name - avoid to add board name if matches with product name" to the asoc tree Mark Brown
2019-11-21 11:51 ` [alsa-devel] [PATCH v2 1/2] ASoC: improve the DMI long card code in asoc-core Mark Brown
2019-11-21 12:02 ` Jaroslav Kysela
2019-11-21 12:11 ` Mark Brown
2019-11-21 15:14 ` Pierre-Louis Bossart [this message]
2019-11-22 19:55 ` [alsa-devel] Applied "ASoC: improve the DMI long card code in asoc-core" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a08eb3a2-49d4-5637-256f-ac8a1debc305@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox