Re: [PATCH v3 1/8] ASoC: qcom: apq8016_sbc.c: Add Quinary support

Konrad Dybcio
2024-08-20T14:30:49Z

On 31.07.2024 5:25 PM, Adam Skladowski wrote:
> From: Vladimir Lypak <vladimir.lypak@gmail.com>
>
> Add support for configuring Quinary Mi2S interface
> it will be used on MSM8953 and MSM8976 platform.
>
> Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> [Adam: Split from MSM8953 support patch,add msg]
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
> ---
> sound/soc/qcom/apq8016_sbc.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c
> index 3023cf180a75..5a29adbd3f82 100644
> --- a/sound/soc/qcom/apq8016_sbc.c
> +++ b/sound/soc/qcom/apq8016_sbc.c
> @@ -20,12 +20,13 @@
> #include "common.h"
> #include "qdsp6/q6afe.h"
>
> -#define MI2S_COUNT (MI2S_QUATERNARY + 1)
> +#define MI2S_COUNT (MI2S_QUINARY + 1)
>
> struct apq8016_sbc_data {
> struct snd_soc_card card;
> void __iomem *mic_iomux;
> void __iomem *spkr_iomux;
> + void __iomem *quin_iomux;
> struct snd_soc_jack jack;
> bool jack_setup;
> int mi2s_clk_count[MI2S_COUNT];
> @@ -86,6 +87,12 @@ static int apq8016_dai_init(struct snd_soc_pcm_runtime *rtd, int mi2s)
> SPKR_CTL_TLMM_DATA1_EN | SPKR_CTL_TLMM_WS_OUT_SEL_SEC |
> SPKR_CTL_TLMM_WS_EN_SEL_SEC, pdata->spkr_iomux);
> break;
> + case MI2S_QUINARY:
> + /* Configure Quinary MI2S */
> + if (!pdata->quin_iomux)
> + return -ENOENT;
> + writel(readl(pdata->quin_iomux) | 0x01, pdata->quin_iomux);

I'm nitpicking, but 0x01 here is BIT(0)

Acked-by: Konrad Dybcio <konradybcio@kernel.org>

Konrad