Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
To: Keyon Jie <yang.jie@linux.intel.com>, alsa-devel@alsa-project.org
Cc: marcin.rajwa@intel.com, pierre-louis.bossart@linux.intel.com,
	Marcin Rajwa <marcin.rajwa@linux.intel.com>
Subject: Re: [PATCH 1/2] ASoC: SOF: ipc: update sof_ipc_stream_params
Date: Tue, 02 Jul 2019 16:29:57 -0700	[thread overview]
Message-ID: <a233dfdbb973251d439197d13b69c867667d3f76.camel@linux.intel.com> (raw)
In-Reply-To: <20190702121144.7809-1-yang.jie@linux.intel.com>

On Tue, 2019-07-02 at 20:11 +0800, Keyon Jie wrote:
> From: Marcin Rajwa <marcin.rajwa@linux.intel.com>
> 
> The host period bytes needs to be passed to firmware.
> Currently this field is used as notification for host
> about period copy completion. Therefore we need to split these
> two informations.
Keyon/Marcin,

Could you please add a bit more context in the commit message on the
need to split these two fields ie.. what usecases need this?

Thanks,
Ranjani
> 
> Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
> ---
>  include/sound/sof/stream.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/sound/sof/stream.h b/include/sound/sof/stream.h
> index 643f175cb479..44acfa62fa69 100644
> --- a/include/sound/sof/stream.h
> +++ b/include/sound/sof/stream.h
> @@ -83,10 +83,10 @@ struct sof_ipc_stream_params {
>  	uint16_t sample_valid_bytes;
>  	uint16_t sample_container_bytes;
>  
> -	/* for notifying host period has completed - 0 means no period
> IRQ */
>  	uint32_t host_period_bytes;
> +	uint16_t no_period_irq; /* 1 means period IRQ mode OFF */
>  
> -	uint32_t reserved[2];
> +	uint16_t reserved[3];
>  	uint16_t chmap[SOF_IPC_MAX_CHANNELS];	/**< channel map -
> SOF_CHMAP_ */
>  } __packed;
>  

  parent reply	other threads:[~2019-07-02 23:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 12:11 [PATCH 1/2] ASoC: SOF: ipc: update sof_ipc_stream_params Keyon Jie
2019-07-02 12:11 ` [PATCH 2/2] ASoC: SOF: Intel: fix reset of host_period_bytes Keyon Jie
2019-07-02 23:29 ` Ranjani Sridharan [this message]
2019-07-03  1:52   ` [PATCH 1/2] ASoC: SOF: ipc: update sof_ipc_stream_params Keyon Jie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a233dfdbb973251d439197d13b69c867667d3f76.camel@linux.intel.com \
    --to=ranjani.sridharan@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=marcin.rajwa@intel.com \
    --cc=marcin.rajwa@linux.intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=yang.jie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox