From: SF Markus Elfring <elfring@users.sourceforge.net>
To: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Takashi Iwai <tiwai@suse.com>
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/4] ASoC: twl4030: Improve a size determination in two functions
Date: Thu, 23 Nov 2017 22:11:11 +0100 [thread overview]
Message-ID: <a26b98ae-532e-4490-098a-7f8592bc32bd@users.sourceforge.net> (raw)
In-Reply-To: <d2edbce1-ffce-9c18-3f50-baa0cdfb0152@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 23 Nov 2017 21:45:55 +0100
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
sound/soc/codecs/twl4030.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index a1f0b45c83ca..946818a0412c 100644
--- a/sound/soc/codecs/twl4030.c
+++ b/sound/soc/codecs/twl4030.c
@@ -236,9 +236,7 @@ static struct twl4030_codec_data *twl4030_get_pdata(struct snd_soc_codec *codec)
"codec");
if (!pdata && twl4030_codec_node) {
- pdata = devm_kzalloc(codec->dev,
- sizeof(struct twl4030_codec_data),
- GFP_KERNEL);
+ pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL);
if (!pdata)
goto put_node;
@@ -2168,8 +2166,7 @@ static int twl4030_soc_probe(struct snd_soc_codec *codec)
{
struct twl4030_priv *twl4030;
- twl4030 = devm_kzalloc(codec->dev, sizeof(struct twl4030_priv),
- GFP_KERNEL);
+ twl4030 = devm_kzalloc(codec->dev, sizeof(*twl4030), GFP_KERNEL);
if (!twl4030)
return -ENOMEM;
snd_soc_codec_set_drvdata(codec, twl4030);
--
2.15.0
next prev parent reply other threads:[~2017-11-23 21:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 21:07 [PATCH 0/4] ALSA SoC TWL4030: Adjustments for two function implementations SF Markus Elfring
2017-11-23 21:08 ` [PATCH 1/4] ASoC: twl4030: Delete an error message for a failed memory allocation in twl4030_get_pdata() SF Markus Elfring
2017-11-27 18:54 ` Applied "ASoC: twl4030: Delete an error message for a failed memory allocation in twl4030_get_pdata()" to the asoc tree Mark Brown
2017-11-23 21:10 ` [PATCH 2/4] ASoC: twl4030: Use common error handling code in twl4030_get_pdata() SF Markus Elfring
2017-11-23 21:11 ` SF Markus Elfring [this message]
2017-11-23 21:12 ` [PATCH 4/4] ASoC: twl4030: Delete an unnecessary variable initialisation " SF Markus Elfring
2017-12-04 14:04 ` [PATCH 0/4] ALSA SoC TWL4030: Adjustments for two function implementations Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a26b98ae-532e-4490-098a-7f8592bc32bd@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).