From: Dmitry Osipenko <digetx@gmail.com>
To: Mark Brown <broonie@kernel.org>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: alsa-devel@alsa-project.org,
pierre-louis.bossart@linux.intel.com,
kuninori.morimoto.gx@renesas.com,
ranjani.sridharan@linux.intel.com
Subject: Re: [PATCH] ASoC: soc-pcm: fix state tracking error in snd_soc_component_open/close()
Date: Mon, 24 Feb 2020 18:47:27 +0300 [thread overview]
Message-ID: <a435d244-573a-4e57-362d-08b7e4a6d012@gmail.com> (raw)
In-Reply-To: <20200224120157.GF6215@sirena.org.uk>
24.02.2020 15:01, Mark Brown пишет:
> On Thu, Feb 20, 2020 at 11:49:55AM +0200, Kai Vehmanen wrote:
>> ASoC component open/close and snd_soc_component_module_get/put are called
>> independently for each component-substream pair, so the logic added in
>> commit dd03907bf129 ("ASoC: soc-pcm: call snd_soc_component_open/close()
>> once") was not sufficient and led to PCM playback and module unload errors.
>>
>> Implement handling of failures directly in soc_pcm_components_open(),
>> so that any successfully opened components are closed upon error with
>> other components. This allows to clean up error handling in
>> soc_pcm_open() without adding more state tracking.
>
> Do people have thoughts on this? I do like this approach but can't
> really test effectively myself.
>
I haven't tried to review this patch, but it works fine on NVIDIA Tegra:
Tested-by: Dmitry Osipenko <digetx@gmail.com>
next prev parent reply other threads:[~2020-02-24 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 9:49 [PATCH] ASoC: soc-pcm: fix state tracking error in snd_soc_component_open/close() Kai Vehmanen
2020-02-24 12:01 ` Mark Brown
2020-02-24 15:47 ` Dmitry Osipenko [this message]
2020-02-24 17:05 ` Pierre-Louis Bossart
2020-02-24 22:21 ` Applied "ASoC: soc-pcm: fix state tracking error in snd_soc_component_open/close()" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a435d244-573a-4e57-362d-08b7e4a6d012@gmail.com \
--to=digetx@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox