From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E159C001E0 for ; Fri, 28 Jul 2023 12:52:55 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4EE7E843; Fri, 28 Jul 2023 14:52:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4EE7E843 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1690548773; bh=JzdEukCtt8cZhLWRKlkkqjM0UmtZtQUt+RZ3eXG9C1A=; h=Date:Subject:To:References:From:In-Reply-To:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From; b=skj/V0YYkUoLfd6E302O5czs/gcFrviu3pdzjOJafSNKoKKw9LB0Ms18P72QeT1aH O/aDykCtulGYfivcNfDl9a9uoNg+fVL7vn4fmmvpKISAZSJqlntRVohQUiF7UKMK5a ByDoY8DSsChHyEsO2tYrFwn/yyZDvxRq3TseHr8k= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6301CF80520; Fri, 28 Jul 2023 14:51:36 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id E1516F8019B; Fri, 28 Jul 2023 14:51:35 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 053FDF8019B; Fri, 28 Jul 2023 14:51:33 +0200 (CEST) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0AB00F80153 for ; Fri, 28 Jul 2023 14:51:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0AB00F80153 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=wZkbNGqQ Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9923833737eso284080066b.3 for ; Fri, 28 Jul 2023 05:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690548689; x=1691153489; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gedJLHyl9jYC/USPCijx0sE3um9fSLBbzPsw2ixUmqY=; b=wZkbNGqQ3uw7mcIwc1dl7W5fqIdyvKuQUlDtB8gOcchltE1RNPokOIfX3a/CvA/g5t mw2xEn50S9OLn2pNFVCuTMP86YFrvZKsDIBDutAbKKuSiTQPY8/b4MCrKdJQYFfOKVv/ Ty3Lw8A0HAfx+lgEd/6uJxOqks62xu8+dJP4KoIOWfeIZFIK1rb2giVKIpibsczYWqqU 7k0zJTnEguhscCH+pXhGphDy2A0CNjWyoqyxlXMi54Vl+hVfx6m9a3Zt8jdwrObAQcnt S/tQrXjg6JBJYzZih7sFc1ERLc5iEP5Uq26CzNJrJcWUunD0PCgjfVnRAEgG4GAUcgk3 KGSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690548689; x=1691153489; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gedJLHyl9jYC/USPCijx0sE3um9fSLBbzPsw2ixUmqY=; b=JNw5B3oxrFYM6jbTWhgWAy0AORmy0BwWIGAXTdyGge9X+JWwH1DzZYcjZ48ctz7vRa lBMuFM9OuxNGVOTcwixe1ecXPKBExCVps3XFXhf+xdvCdY3TYo0tE5HSQQVf5HpH/9Xn oiXmPJVxTws7Wnlre9JpU8QI87DH6RB8B8nYPYD7oiXawul2h6zAcDkXIygpHRn0Tfdt Q1Tdc2EP3uTnFaYO2jxNz+hzcgrFuc92YTGrRs8GcDQ7agaynndPPZgSyZb/V33rVkHL zrh8j1JvXUYYj3q+7aCVoe9MUnY4n3z5AuFwwanLGqKtrgNwWcouqfzhNA6+RUNmiLwV gD7A== X-Gm-Message-State: ABy/qLaXPAMPrb9Gu+sCUIBovB44r5fXksyIkcI2d6brtXvEziAjvaHf DujC2Zh1AcUtFC0iQKmkt70n9A== X-Google-Smtp-Source: APBJJlHax6AsxJudUM5VqzR8XMQAFX9jqhmnuuAP0jJ/YQ0xu9Ni7Sg1fWIzJHA9rNtfwWtbo3ixhQ== X-Received: by 2002:a17:906:319a:b0:994:34a2:8727 with SMTP id 26-20020a170906319a00b0099434a28727mr2157378ejy.41.1690548688933; Fri, 28 Jul 2023 05:51:28 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id sd26-20020a170906ce3a00b0099bc08862b6sm2054522ejb.171.2023.07.28.05.51.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 05:51:28 -0700 (PDT) Message-ID: Date: Fri, 28 Jul 2023 14:51:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 6/6] ASoC: dt-bindings: mediatek,mt7986-afe: add audio afe document Content-Language: en-US To: Maso Huang , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Trevor Wu , Arnd Bergmann , Mars Chen , Allen-KH Cheng , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230728090819.18038-1-maso.huang@mediatek.com> <20230728090819.18038-7-maso.huang@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20230728090819.18038-7-maso.huang@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: 3T4CA6VL3XNOOOCMGIPZ2CLOIQZFALSH X-Message-ID-Hash: 3T4CA6VL3XNOOOCMGIPZ2CLOIQZFALSH X-MailFrom: krzysztof.kozlowski@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 28/07/2023 11:08, Maso Huang wrote: > Add mt7986 audio afe document. > > Signed-off-by: Maso Huang Thank you for your patch. There is something to discuss/improve. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - assigned-clocks > + - assigned-clock-parents You should constrain your clocks per variants. I doubt that they are really so flexible/optional on each SoC... or maybe missing clocks are result of unimplemented parts in the driver? But then this should not really affect bindings. Bindings still should require such clocks. Your DTS can always provide a <0>, if needed. > + > +additionalProperties: false Best regards, Krzysztof