From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: Re: [PATCH 1/5] ASoC: atmel: enable SSC_PCM_DMA in Kconfig Date: Tue, 23 Jul 2019 17:27:26 +0000 Message-ID: References: <1f3a4256-58de-27a4-8095-54fc6baa6d89@microchip.com> <20190723164312.GA4772@qmqm.qmqm.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190723164312.GA4772@qmqm.qmqm.pl> Content-Language: en-US Content-ID: <55324B5682468F4A96B0E7EC8EA8DA66@namprd11.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: mirq-linux@rere.qmqm.pl Cc: alsa-devel@alsa-project.org, alexandre.belloni@bootlin.com, lgirdwood@gmail.com, tiwai@suse.com, Ludovic.Desroches@microchip.com, broonie@kernel.org, perex@perex.cz, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On 23.07.2019 19:43, mirq-linux@rere.qmqm.pl wrote: > External E-Mail > = > = > On Tue, Jul 23, 2019 at 01:36:37PM +0000, Codrin.Ciubotariu@microchip.com= wrote: >> On 22.07.2019 21:27, Micha=B3 Miros=B3aw wrote: >>> Allow SSC to be used on platforms described using audio-graph-card >>> in Device Tree. >>> >>> Signed-off-by: Micha=B3 Miros=B3aw >>> --- >>> sound/soc/atmel/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig >>> index 06c1d5ce642c..9ef9d25bb517 100644 >>> --- a/sound/soc/atmel/Kconfig >>> +++ b/sound/soc/atmel/Kconfig >>> @@ -25,7 +25,7 @@ config SND_ATMEL_SOC_DMA >>> default y if SND_ATMEL_SOC_SSC_DMA=3Dy || (SND_ATMEL_SOC_SSC_DMA=3D= m && SND_ATMEL_SOC_SSC=3Dy) >>> = >>> config SND_ATMEL_SOC_SSC_DMA >>> - tristate >>> + tristate "SoC PCM DAI support for AT91 SSC controller using DMA" >> >> Could you please make something similar for SND_ATMEL_SOC_SSC_PDC? Also, >> I think that it should select ATMEL_SSC, to be able to use >> simple/graph-card with SSC. > = > Hmm. The Kconfig dependencies seems overly complicated, do you mind if I > get rid of most of the entries in the process? > = > Best Regards, > Micha=B3=A0Miros=B3aw > = 'select' creates recursive dependencies with our machine drivers, but 'depends on' should work. The complication comes from the = fact that PDC and DMA support for SSC can be both enabled at the same = time, so I think we need all of them... I am reviewing the rest of your patches, so bear with me please. Best regards, Codrin