From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48229C433FE for ; Sun, 2 Oct 2022 08:36:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C77902A5C; Sun, 2 Oct 2022 10:35:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C77902A5C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1664699789; bh=fzEeaCEz4b7Nafq06ViNPP9BBrASb9GdM1dJ0bBxeyg=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mFnufmLxfV0QXVljnc+1atH5HO4HiFEew3JwGNe9oS39SJ23vU/Qss8FVHKFHSY+x umT1xYNExdTRktTMEdh7L5T5F06MiVUhVTYyGkr6Z/NWNbk/59wf1tEW6rLFsAC/oC /pZJBTsEIWEZflmHmk0i27QEnbJ4KsldxGq3DccI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 65EFAF80087; Sun, 2 Oct 2022 10:35:39 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 997AAF80246; Sun, 2 Oct 2022 10:35:38 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F3A83F800A7 for ; Sun, 2 Oct 2022 10:35:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F3A83F800A7 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SIDH0yws" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 54823B808D0; Sun, 2 Oct 2022 08:35:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74EAAC433B5; Sun, 2 Oct 2022 08:35:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664699733; bh=fzEeaCEz4b7Nafq06ViNPP9BBrASb9GdM1dJ0bBxeyg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SIDH0ywsK6X8/liN5r8QYeG6GB/75JrTTnRQD7cGXhKT/xe32Pt2OBlLEU1VgCJcN WGb97qmOzPYywXDQNetOp36j9k9rFmldy2cOg8F9AQKipAc5uH5oKqSz7CU3Nt2Yyb fAyCd7SqX+7/dTdbRc0oiNufRnzB8iIsYLAr5VTMwvObXHR5vlbTdb4Kz0lRWcqfud XDermtnCZoVsCmMqFz3DBeU3VpCe9ZgxOL/ROse1QTXC8oCQ6Zjfg8HYLzweWuk6x7 wR+NHYofe2ODahCwNzox4IlTkD5yWV/d/eZmmws59gkkxIW1ZoGjG2gJOuYj2XEano lckDxOQtcRBjA== Message-ID: Date: Sun, 2 Oct 2022 10:35:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 2/2] ASoC: wm8961: add support for devicetree Content-Language: en-US To: Doug Brown , Liam Girdwood , Mark Brown References: <20221001200039.21049-3-doug@schmorgal.com> <202210020642.ts8UPw06-lkp@intel.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, kbuild-all@lists.01.org, patches@opensource.cirrus.com, Takashi Iwai , Rob Herring X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 02/10/2022 07:04, Doug Brown wrote: > On 10/1/2022 3:23 PM, kernel test robot wrote: > >>>> sound/soc/codecs/wm8961.c:974:34: warning: 'wm8961_of_match' defined but not used [-Wunused-const-variable=] >> 974 | static const struct of_device_id wm8961_of_match[] = { >> | ^~~~~~~~~~~~~~~ > > Oops, nice catch by the kernel test robot. I will submit a V2 patch that Now I see the report about issue I wrote to you. It's not particular nice catch of robot... it's visible from the code and easily testable by yourself. Even without compile test... The code was just not tested for warnings. > does this part exactly how the wm8960 driver does it, including > .of_match_table in wm8961_i2c_driver. Waiting to see if I get any other > feedback on V1 first. maybe_unused instead of ifdefs. Best regards, Krzysztof