Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: twl4030: Use modern ASoC DAI format terminology
Date: Mon, 28 Feb 2022 14:23:20 +0200	[thread overview]
Message-ID: <a6dd46f5-c0e7-4972-c45d-d45a87d613c5@gmail.com> (raw)
In-Reply-To: <20220223003046.1697784-1-broonie@kernel.org>



On 23/02/2022 02:30, Mark Brown wrote:
> As part of moving to remove the old style defines for the bus clocks update
> the twl4030 driver to use more modern terminology for clocking.

Thanks Mark!

Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>

> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  sound/soc/codecs/twl4030.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
> index e059711ff293..0ba3546ef870 100644
> --- a/sound/soc/codecs/twl4030.c
> +++ b/sound/soc/codecs/twl4030.c
> @@ -1840,13 +1840,12 @@ static int twl4030_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
>  	old_format = twl4030_read(component, TWL4030_REG_AUDIO_IF);
>  	format = old_format;
>  
> -	/* set master/slave audio interface */
> -	switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> -	case SND_SOC_DAIFMT_CBM_CFM:
> +	switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
> +	case SND_SOC_DAIFMT_CBP_CFP:
>  		format &= ~(TWL4030_AIF_SLAVE_EN);
>  		format &= ~(TWL4030_CLK256FS_EN);
>  		break;
> -	case SND_SOC_DAIFMT_CBS_CFS:
> +	case SND_SOC_DAIFMT_CBC_CFC:
>  		format |= TWL4030_AIF_SLAVE_EN;
>  		format |= TWL4030_CLK256FS_EN;
>  		break;
> @@ -2038,9 +2037,8 @@ static int twl4030_voice_set_dai_fmt(struct snd_soc_dai *codec_dai,
>  	old_format = twl4030_read(component, TWL4030_REG_VOICE_IF);
>  	format = old_format;
>  
> -	/* set master/slave audio interface */
> -	switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> -	case SND_SOC_DAIFMT_CBM_CFM:
> +	switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
> +	case SND_SOC_DAIFMT_CBP_CFP:
>  		format &= ~(TWL4030_VIF_SLAVE_EN);
>  		break;
>  	case SND_SOC_DAIFMT_CBS_CFS:

-- 
Péter

  reply	other threads:[~2022-02-28 12:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23  0:30 [PATCH] ASoC: twl4030: Use modern ASoC DAI format terminology Mark Brown
2022-02-28 12:23 ` Péter Ujfalusi [this message]
2022-02-28 19:15 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6dd46f5-c0e7-4972-c45d-d45a87d613c5@gmail.com \
    --to=peter.ujfalusi@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox