From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5525FEB64D9 for ; Thu, 29 Jun 2023 08:20:29 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5C6F8825; Thu, 29 Jun 2023 10:19:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5C6F8825 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1688026827; bh=nZeawW1oMN2HuGCf+TgAnAiNf1H7F95ZCg0NNjoviRI=; h=Date:From:Subject:To:Cc:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=FXBwqlDAdO/U9lwUiOW++E3XYruf6JSL2yW7nsFncM/IV+QEB8dyF8IUD9rZA9HVF WwPcO5Jmx3/sNK2VwDAnnsqraSn0rWw+9f9q0OWAYvjb6141XRfLHv1TKTw49fAAlw mWzp/jZPJryTzZe3/c7kn37RJadUWsRl8OkAvBWY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1E064F80093; Thu, 29 Jun 2023 10:19:12 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 310C3F80093; Thu, 29 Jun 2023 10:19:11 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3BFD3F80246; Thu, 29 Jun 2023 10:19:07 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 37191F80093 for ; Thu, 29 Jun 2023 10:19:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 37191F80093 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=ONDmelxV DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688026743; x=1719562743; h=message-id:date:mime-version:from:subject:to:cc: references:in-reply-to:content-transfer-encoding; bh=nZeawW1oMN2HuGCf+TgAnAiNf1H7F95ZCg0NNjoviRI=; b=ONDmelxVzvTjwK5lsJCoxwRmZyfbix2UtMXvaebEsHdjj662sWkC8y/9 04trU9vkj/+4eEcix6rTYsxS6Af13muZXkVCkzP5tgXxk/jrDt1hxsyyp xuZ7jJPwayfduSwq1zYrksZ/CqfFMnigwS39TaSxlUecRughXnZq91ig7 5tl8HAReL8zwcg7PyIkqnCeP9z7H1x3Gv0Cjj0KWHPuNvkiFfERviEUmN 3lISy1f5rn437yolSR2Kk1QxFFIzSIbISB9OAqtSmO+1P6T5iGI5U20HU jz1iTCbqq7QGT0QWGH/Au7hncso8i2KutSMx56UxvdQnH4BizAQQDIlLh A==; X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="351854302" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="351854302" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2023 01:18:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="891331178" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="891331178" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.99.16.144]) ([10.99.16.144]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2023 01:18:53 -0700 Message-ID: Date: Thu, 29 Jun 2023 10:18:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= Subject: Re: [RFC PATCH 1/8] PCI: Add Intel Audio DSP devices to pci_ids.h To: Andy Shevchenko Cc: Bjorn Helgaas , Mark Brown , Takashi Iwai , alsa-devel@alsa-project.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Pierre-Louis Bossart , Kai Vehmanen References: <20230628205135.517241-1-amadeuszx.slawinski@linux.intel.com> <20230628205135.517241-2-amadeuszx.slawinski@linux.intel.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Message-ID-Hash: B36JYHYSX6RAD4B5MGEDXQZ5HCTJYDIR X-Message-ID-Hash: B36JYHYSX6RAD4B5MGEDXQZ5HCTJYDIR X-MailFrom: amadeuszx.slawinski@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 6/28/2023 4:44 PM, Andy Shevchenko wrote: > On Wed, Jun 28, 2023 at 10:51:28PM +0200, Amadeusz Sławiński wrote: >> Those IDs are mostly sprinkled between HDA, Skylake, SOF and avs drivers. >> Almost every use contains additional comments to identify to which >> platform those IDs refer to. Add those IDs to pci_ids.h header, so that >> there is one place which defines those names. > > ... > >> #define PCI_DEVICE_ID_INTEL_5400_FBD0 0x4035 >> #define PCI_DEVICE_ID_INTEL_5400_FBD1 0x4036 >> +#define PCI_DEVICE_ID_INTEL_HDA_JSL_N 0x4dc8 >> +#define PCI_DEVICE_ID_INTEL_HDA_TGL_H 0x43c8 >> +#define PCI_DEVICE_ID_INTEL_HDA_EHL_0 0x4b55 >> +#define PCI_DEVICE_ID_INTEL_HDA_EHL_3 0x4b58 > > Can it be kept sorted by a value? > > Didn't check the full list, though. > My mistake, I've tried to add them in order, but must have missed this one, will review whole list again.