From: Jack Yu <jack.yu@realtek.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Cc: "Oder Chiou" <oder_chiou@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"kent_chen@realtek.com [陳建宏]" <kent_chen@realtek.com>,
"Derek [方德義]" <derek.fang@realtek.com>,
"Shuming [范書銘]" <shumingf@realtek.com>,
"Flove(HsinFu)" <flove@realtek.com>
Subject: RE: [PATCH] ASoC: rt1011: add i2s reference control for rt1011
Date: Thu, 9 Sep 2021 02:40:38 +0000 [thread overview]
Message-ID: <a9d9074e52c941e8bddc34f4d364a1ae@realtek.com> (raw)
In-Reply-To: <9f76a420-44c6-ad6d-4442-275ba4459b40@linux.intel.com>
> -----Original Message-----
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Sent: Wednesday, September 8, 2021 11:23 PM
> To: Jack Yu <jack.yu@realtek.com>; broonie@kernel.org;
> lgirdwood@gmail.com
> Cc: Oder Chiou <oder_chiou@realtek.com>; alsa-devel@alsa-project.org;
> lars@metafoo.de; kent_chen@realtek.com [陳建宏]
> <kent_chen@realtek.com>; Derek [方德義] <derek.fang@realtek.com>;
> Shuming [范書銘] <shumingf@realtek.com>; Flove(HsinFu)
> <flove@realtek.com>
> Subject: Re: [PATCH] ASoC: rt1011: add i2s reference control for rt1011
>
> On 9/7/21 9:17 PM, Jack Yu wrote:
> >
> >> -----Original Message-----
> >> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> >> Sent: Tuesday, September 7, 2021 10:54 PM
> >> To: Jack Yu <jack.yu@realtek.com>; broonie@kernel.org;
> >> lgirdwood@gmail.com
> >> Cc: Oder Chiou <oder_chiou@realtek.com>; alsa-devel@alsa-project.org;
> >> lars@metafoo.de; kent_chen@realtek.com [陳建宏]
> >> <kent_chen@realtek.com>; Derek [方德義] <derek.fang@realtek.com>;
> >> Shuming [范書銘] <shumingf@realtek.com>; Flove(HsinFu)
> >> <flove@realtek.com>
> >> Subject: Re: [PATCH] ASoC: rt1011: add i2s reference control for
> >> rt1011
> >>
> >> On 9/6/21 5:12 AM, Jack Yu wrote:
> >>> Add i2s reference control for rt1011 amp.
> >>>
> >>> Signed-off-by: Jack Yu <jack.yu@realtek.com>
> >>
> >>> +static const char * const rt1011_i2s_ref[] = {
> >>> + "None", "Left Channel", "Right Channel"
> >>> +};
> >>
> >>> +enum {
> >>> + RT1011_I2S_REF_NONE,
> >>> + RT1011_I2S_REF_LEFT_CH,
> >>> + RT1011_I2S_REF_RIGHT_CH,
> >>> +};
> >>
> >> is it possible to get Left-Right-mix (mixed on rt1011) and Left-Right
> >> (two channels, with the application selecting what they want)?
> >
> > It's a mono amp, so there's no Left-Right-mix setting.
> > And for the choice of Left-Right channel, it's already available with this
> patch.
>
> So it's just to place a mono reference in either left or right channel of the I2S
> link? Why not dual-mono as well then?
The patch is a specific control for two amps to send AEC data on single I2S data input pin by standard I2S protocol.
If there are two I2S input from SoC, we can add dual-mono mode for it, but so far there is no requirement regarding to this mode.
> ------Please consider the environment before printing this e-mail.
next prev parent reply other threads:[~2021-09-09 2:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 10:12 [PATCH] ASoC: rt1011: add i2s reference control for rt1011 Jack Yu
2021-09-07 14:53 ` Pierre-Louis Bossart
2021-09-08 2:17 ` Jack Yu
2021-09-08 15:22 ` Pierre-Louis Bossart
2021-09-09 2:40 ` Jack Yu [this message]
2021-09-09 3:25 ` Pierre-Louis Bossart
2021-09-09 5:17 ` Jack Yu
2021-09-13 10:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9d9074e52c941e8bddc34f4d364a1ae@realtek.com \
--to=jack.yu@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=kent_chen@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox