* Re: [PATCH] ALSA: hda/realtek: Add quirk for HP Spectre 14t-ea100
2025-09-18 19:27 [PATCH] ALSA: hda/realtek: Add quirk for HP Spectre 14t-ea100 Kaden Berger
@ 2025-09-19 7:41 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2025-09-19 7:41 UTC (permalink / raw)
To: Kaden Berger; +Cc: alsa-devel
On Thu, 18 Sep 2025 21:27:20 +0200,
Kaden Berger wrote:
>
Could you give a proper patch description? It should describe what
this patch does, why it's needed, etc.
Then put your Signed-off-by tag. It's a legal requirement.
> --- patch_realtek.c 2025-06-22 11:36:47.365528716 -0500
> +++ patch_realtek.c.new 2025-09-18 13:59:13.610449218 -0500
The patch should be against a full path with a prefix to be applied
with -p1 option. And, since 6.17 kernel, the code was moved to
another file path, so the patch should appear like:
--- a/sound/hda/codecs/realtek/alc269.c ....
+++ a/sound/hda/codecs/realtek/alc269.c ....
For the details about the patch submission, please refer to
Documentation/submitting-patches.rst.
> @@ -10779,6 +10779,7 @@
> SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> + SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14t-ea100", ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
> SND_PCI_QUIRK(0x103c, 0x89e7, "HP Elite x2 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8a20, "HP Laptop 15s-fq5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
The change itself is pretty trivial, and if you rather let other people
fixing it, let us know. If you'd like to resubmit in a proper format,
that'll be appreciated, too, of course.
thanks,
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread