Re: [PATCH v1 7/8] ASoC: tas2783A: use acpi initialisation table

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Thu, Nov 20, 2025 at 02:50:49PM +0530, Niranjan H Y wrote:
> This patch adds support for parsing the initilisation
> data from ACPI table. This table is required to configure
> each device correctly so that correct channel's data is
> selected during playback.
> 
> Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
> ---
>  sound/soc/codecs/Kconfig       |  1 +
>  sound/soc/codecs/tas2783-sdw.c | 61 +++++++++++++++++++++++++++++++---
>  2 files changed, 58 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 433af9bc7..94d66e4d5 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -2146,6 +2146,7 @@ config SND_SOC_TAS2781_I2C
>  config SND_SOC_TAS2783_SDW
>  	tristate "Texas Instruments TAS2783 speaker amplifier (sdw)"
>  	depends on SOUNDWIRE
> +	depends on SND_SOC_SDCA

Great to see some of the SDCA library stuff starting to be useful
for people :-)

> -		ret = regmap_multi_reg_write(tas_dev->regmap, tas2783_init_seq,
> -					     ARRAY_SIZE(tas2783_init_seq));
> -		tas_dev->hw_init = true;
> +		if (tas_dev->sa_func_data) {
> +			for (i = 0; i < tas_dev->sa_func_data->num_init_table; i++) {
> +				ret = regmap_write(tas_dev->regmap,
> +						   tas_dev->sa_func_data->init_table[i].addr,
> +						   tas_dev->sa_func_data->init_table[i].val);
> +				if (ret)
> +					break;
> +			}

Should be able to use sdca_regmap_write_init() here once the
patch is merged:

https://lore.kernel.org/linux-sound/20251106114422.906370-11-ckeepax@opensource.cirrus.com/

No point holding up this patch for it, but would be good to move
it across once the core function is merged. And if you wanted to
test the core patch out check it works for you that would be
amazing.

> +		} else {
> +			ret = regmap_multi_reg_write(tas_dev->regmap, tas2783_init_seq,
> +						     ARRAY_SIZE(tas2783_init_seq));
> +		}
> +
> +		if (ret)
> +			dev_err(tas_dev->dev,
> +				"init writes failed, err=%d", ret);
> +		else
> +			tas_dev->hw_init = true;
>  	}
>  
> +	/* check if we have any SDCA function data available */
> +	if (peripheral->sdca_data.num_functions > 0) {
> +		dev_dbg(dev, "SDCA functions found: %d", peripheral->sdca_data.num_functions);
> +
> +		/* Look for Smart Amp function type */
> +		for (i = 0; i < peripheral->sdca_data.num_functions; i++) {
> +			if (peripheral->sdca_data.function[i].type ==
> +			    SDCA_FUNCTION_TYPE_SMART_AMP) {
> +				dev_info(dev, "Found Smart Amp function at index %d", i);
> +				break;
> +			}
> +		}
> +	}

I do wonder if we should add a core function for this search, I
am guessing this will become a fairly common pattern. But again
no need to hold up your patches for that.

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles