From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0ABAC2D0A3 for ; Fri, 6 Nov 2020 14:58:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C6182151B for ; Fri, 6 Nov 2020 14:58:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="oCklj8Ar" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C6182151B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C8EE91684; Fri, 6 Nov 2020 15:58:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C8EE91684 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1604674734; bh=2fuo3KyDmAUWXxViAA/JAWxQeMOrwkX97EwNaDmiSwk=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oCklj8ArmuAllV0OqkEiRnBDA63XMPXkIaKJOTXk34ZNmPmPj+dXqB87vgTmcQX5m C3bHCIJwJeEVTDW7x5JEXy4Z+3QzNIfabB7RMLOJkTgV7RE8amfd648Qqnx8prMbln OM7x3UA8hDS9CqP5eEX6AQ1DVrFp7NNrHDtOJXjA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 281CAF80232; Fri, 6 Nov 2020 15:58:04 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2712BF80234; Fri, 6 Nov 2020 15:58:02 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 98BEAF80150 for ; Fri, 6 Nov 2020 15:57:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 98BEAF80150 IronPort-SDR: 2CgUjiYxBVeh/xXQxXm/2+OHbx+kXiTcdd5yPjggkMoREabfi5PmzKllRhdEt9WcOmloXWqK+M JOhlK8dQeZrw== X-IronPort-AV: E=McAfee;i="6000,8403,9796"; a="169701132" X-IronPort-AV: E=Sophos;i="5.77,456,1596524400"; d="scan'208";a="169701132" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 06:57:53 -0800 IronPort-SDR: OmJuWz8P06aSUlik6lktFYd51aVruH6q5z3D2X9Iq5Q+6GJ62vG74zu84YOCVReMfoeSkURV4U 3zL4k19n/eYQ== X-IronPort-AV: E=Sophos;i="5.77,456,1596524400"; d="scan'208";a="472090337" Received: from robrodri-mobl1.amr.corp.intel.com (HELO [10.209.98.80]) ([10.209.98.80]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 06:57:52 -0800 Subject: Re: [PATCH] ASoC: nau8315: add codec driver To: Mark Brown , CTLIN0 References: <20201102023212.594137-1-CTLIN0@nuvoton.com> <0adb99c2-d0d9-5052-c163-4d9a341239fc@linux.intel.com> <20201105150249.GC4856@sirena.org.uk> <20201106122058.GC49612@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: Date: Fri, 6 Nov 2020 08:57:51 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201106122058.GC49612@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: ALSA development , YHCHuang@nuvoton.com, WTLI@nuvoton.com, KCHSU0@nuvoton.com, Liam Girdwood , Tzung-Bi Shih X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 11/6/20 6:20 AM, Mark Brown wrote: > On Fri, Nov 06, 2020 at 11:31:36AM +0800, CTLIN0 wrote: > >> Thanks for your comments. However, I also agree the opinion from >> Tzung-Bi Shih @ Google. >> May I confirm whether I should keep this patch, and remove dapm widget >> of EN_PIN next patch? > > Please send incremental patches on top of this one with any changes. EN_PIN is not strictly required but as discussed it provides additional flexibility for machine drivers, so probably better to keep it?