From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: wangweidong.a@awinic.com
Cc: alsa-devel@alsa-project.org, steve@sk2.org,
tanureal@opensource.cirrus.com, cezary.rojewski@intel.com,
linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org,
krzysztof.kozlowski+dt@linaro.org, zhuning0077@gmail.com,
liweilei@awinic.com, pierre-louis.bossart@linux.intel.com,
povik+lin@cutebit.org, flatmax@flatmax.com,
devicetree@vger.kernel.org, ckeepax@opensource.cirrus.com,
stephan@gerhold.net, zhaolei@awinic.com,
james.schulman@cirrus.com, rf@opensource.cirrus.com,
robh+dt@kernel.org, shumingf@realtek.com, tiwai@suse.com,
duanyibo@awinic.com, lgirdwood@gmail.com, yijiangtao@awinic.com,
broonie@kernel.org
Subject: Re: [PATCH V8 5/5] ASoC: dt-bindings: Add schema for "awinic, aw883xx"
Date: Tue, 3 Jan 2023 13:03:35 +0100 [thread overview]
Message-ID: <abfddd5f-1491-0696-548d-2faec4568302@linaro.org> (raw)
In-Reply-To: <20230103112703.382153-1-wangweidong.a@awinic.com>
On 03/01/2023 12:27, wangweidong.a@awinic.com wrote:
> Hi Krzysztof
>
> On 30/12/2022 10:34, wangweidong.a@awinic.com wrote:
>>> From: Weidong Wang <wangweidong.a@awinic.com>
>>>
>>> Add a DT schema for describing Awinic AW883xx audio amplifiers. They are
>>> controlled using I2C.
>>>
>>> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com>
>>> ---
>>> .../bindings/sound/awinic,aw883xx.yaml | 49 +++++++++++++++++++
>>> 1 file changed, 49 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
>>> new file mode 100644
>>> index 000000000000..b677427ebcd1
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
>>> @@ -0,0 +1,49 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/sound/awinic,aw883xx.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Awinic AW883xx Smart Audio Amplifier
>>> +
>>> +maintainers:
>>> + - Stephan Weidong Wang <wangweidong.a@awinic.com>
>>> +
>>> +description:
>>> + The Awinic AW883XX is an I2S/TDM input, high efficiency
>>> + digital Smart K audio amplifier with an integrated 10.25V
>>> + smart boost convert.
>>> +
>>> +allOf:
>>> + - $ref: dai-common.yaml#
>>> +
>>> +properties:
>>> + compatible:
>>> + const: awinic,aw883xx
>
>> Now the question what does "xx" stand for? I cannot find such product on
>> awinic website:
>> https://www.awinic.com/En/Index/queryAll/wd/aw883xx.html
>
> xx represents our company's aw88394 and aw88395 chips,Aw88395 chips can be found on
> https://www.awinic.com/cn/detail/index/catid/229/id/48/title/AW88395CSR.html
> The aw88394 chip will be available on the website in the near future.
OK, then it has to be changed. Wildcards are not allowed in compatibles,
so please use a specific compatible (oneOf for a case specific
compatible alone and for a case of two compatibles with fallback;
assuming the fallback is applicable to others).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-03 12:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 9:34 [PATCH V8 0/5] ASoC: codecs: Add Awinic AW883XX audio amplifier driver wangweidong.a
2022-12-30 9:34 ` [PATCH V8 1/5] ASoC: codecs: Add i2c and codec registration for aw883xx and their associated operation functions wangweidong.a
2022-12-30 12:32 ` Christophe JAILLET
2023-01-03 20:17 ` Mark Brown
2022-12-30 9:34 ` [PATCH V8 2/5] ASoC: codecs: Aw883xx function for ACF file parse and check wangweidong.a
2022-12-30 9:34 ` [PATCH V8 3/5] ASoC: codecs: Aw883xx common function for ALSA Audio Driver wangweidong.a
2022-12-30 9:34 ` [PATCH V8 4/5] ASoC: codecs: Aw883xx chip register file, data type file and Kconfig Makefile wangweidong.a
2022-12-31 3:06 ` kernel test robot
2023-01-06 7:09 ` Dan Carpenter
2022-12-30 9:34 ` [PATCH V8 5/5] ASoC: dt-bindings: Add schema for "awinic,aw883xx" wangweidong.a
2022-12-30 10:34 ` [PATCH V8 5/5] ASoC: dt-bindings: Add schema for "awinic, aw883xx" Krzysztof Kozlowski
2023-01-03 11:27 ` wangweidong.a
2023-01-03 12:03 ` Krzysztof Kozlowski [this message]
2022-12-30 12:00 ` Stephan Gerhold
2022-12-30 16:34 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abfddd5f-1491-0696-548d-2faec4568302@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=duanyibo@awinic.com \
--cc=flatmax@flatmax.com \
--cc=james.schulman@cirrus.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liweilei@awinic.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=povik+lin@cutebit.org \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=shumingf@realtek.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=stephan@gerhold.net \
--cc=steve@sk2.org \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=wangweidong.a@awinic.com \
--cc=yijiangtao@awinic.com \
--cc=zhaolei@awinic.com \
--cc=zhuning0077@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox