From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 786BAC43461 for ; Tue, 8 Sep 2020 13:57:37 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6392023C42 for ; Tue, 8 Sep 2020 13:57:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="MIRydaHl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6392023C42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 36BF61719; Tue, 8 Sep 2020 15:56:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 36BF61719 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599573454; bh=w0GM3yjscwjQaaXAnlkfb1IWnxHe0IcfgKRykPzyaPI=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MIRydaHlxfDa4C4uDlmR57hz8AbxG2G9aD0s2GkbzOBl9Q5kVGrh/xF3gA7miOWGn wuUyUpeQcME8/Rl7ZJTGDnOVAAmsgKTJ2X54Dcm75eDOXsAnCCRLEU0zkXommvcs1m jq517bIg8u5QuIvv044RKiT3eYXjCSGFboLuoLg4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BC8C4F801F2; Tue, 8 Sep 2020 15:56:43 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1E292F80264; Tue, 8 Sep 2020 15:56:41 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C0577F8015F for ; Tue, 8 Sep 2020 15:56:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C0577F8015F IronPort-SDR: QeS/Z45Lksr174DZfKbiVSMBm1Tq0hwgs99/8kWF7XgGYrrZYj4Ad5jy6X6DHF3gy/Yw6y0jVE Wk67NmVHOf1Q== X-IronPort-AV: E=McAfee;i="6000,8403,9737"; a="222339379" X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="222339379" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 06:56:27 -0700 IronPort-SDR: teJpYva7dmhExSNbTzHV8zh5qZlK7Qb63IZhY9bLtbpHc7vOZpnf08GckvTTKZVmfydKGskSeF gr5iJMG6ycMQ== X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="448793214" Received: from mgarber-mobl1.amr.corp.intel.com (HELO [10.212.179.134]) ([10.212.179.134]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 06:56:26 -0700 Subject: Re: [PATCH v2 3/4] soundwire: qcom: add support for mmio soundwire master devices To: Jonathan Marek , linux-arm-msm@vger.kernel.org References: <20200905173905.16541-1-jonathan@marek.ca> <20200905173905.16541-4-jonathan@marek.ca> From: Pierre-Louis Bossart Message-ID: Date: Tue, 8 Sep 2020 08:56:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200905173905.16541-4-jonathan@marek.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: "moderated list:SOUNDWIRE SUBSYSTEM" , open list , Bjorn Andersson , Vinod Koul , Andy Gross , Sanyog Kale , Bard Liao X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > @@ -764,8 +786,11 @@ static int qcom_swrm_probe(struct platform_device *pdev) > if (!ctrl->regmap) > return -EINVAL; > } else { > - /* Only WCD based SoundWire controller is supported */ > - return -ENOTSUPP; > + ctrl->reg_read = qcom_swrm_cpu_reg_read; > + ctrl->reg_write = qcom_swrm_cpu_reg_write; > + ctrl->mmio = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(ctrl->mmio)) > + return PTR_ERR(ctrl->mmio); Shouldn't this be conditional on SLIMBUS being enabled, as done in your patch2? > } > > ctrl->irq = of_irq_get(dev->of_node, 0); >