From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BA74C2D0DC for ; Thu, 2 Jan 2020 21:23:02 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9800F20848 for ; Thu, 2 Jan 2020 21:23:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ryJ2bnUy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9800F20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A714416E5; Thu, 2 Jan 2020 22:22:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A714416E5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1578000179; bh=3yMzyI8B53gAyxc4/JZltbsLKmq8lZo0DVmLQV1Alyw=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ryJ2bnUyJgFxXMcRwDTRV8tND179Zz4EgADE1TfiIHOTbF479fGbYn8imyAJIealy p3R6lA2m+tS4d6H34yu7t/y1VG7eiAq4nDNUp9MNss6Bx9FUdwtUpfCsNJxuDlMArQ Cd55VfmvZhiq3wnUhike+M+O/dR9oe6V/yCj58gI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AC8FEF8029A; Thu, 2 Jan 2020 22:18:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 73DECF80278; Thu, 2 Jan 2020 22:18:42 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 85B27F8026F for ; Thu, 2 Jan 2020 22:18:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 85B27F8026F X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2020 13:18:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,388,1571727600"; d="scan'208";a="224819867" Received: from ybabin-mobl1.amr.corp.intel.com (HELO [10.252.139.105]) ([10.252.139.105]) by fmsmga001.fm.intel.com with ESMTP; 02 Jan 2020 13:18:36 -0800 To: shumingf@realtek.com, broonie@kernel.org, lgirdwood@gmail.com References: <20191227054445.27223-1-shumingf@realtek.com> From: Pierre-Louis Bossart Message-ID: Date: Thu, 2 Jan 2020 14:37:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191227054445.27223-1-shumingf@realtek.com> Content-Language: en-US Cc: oder_chiou@realtek.com, jack.yu@realtek.com, alsa-devel@alsa-project.org, lars@metafoo.de, Vinod Koul , derek.fang@realtek.com, flove@realtek.com, bard.liao@intel.com, pierre-louis.bossart@intel.com Subject: Re: [alsa-devel] [PATCH] ASoC: rt711: add rt711 codec driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 12/26/19 11:44 PM, shumingf@realtek.com wrote: > From: Shuming Fan > > This is the initial codec driver for rt711. > > Signed-off-by: Shuming Fan Thanks Shuming. I will add my own Tested-by: Pierre-Louis Bossart tag, but this driver was also tested by others at Intel, including Bard Liao and Rander Wang, on CometLake, IceLake and TigerLake platforms. I am not aware of any issues with this codec, and jack detection was tested extensively. The key point to be reviewed is the use of regmap, where we disable access to the registers until the device becomes ATTACHED (cache-only), and also make sure hw calibration is rerun (cache-bypass) before restoring settings in the resume step. This patch also depends on interface changes on the SoundWire side, see below what Vinod provided before the holiday break -Pierre The following changes since commit e42617b825f8073569da76dc4510bfa019b1c35a: Linux 5.5-rc1 (2019-12-08 14:57:55 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire.git tags/sdw_interfaces_5.6 for you to fetch changes up to 09f6a72d014386939d21899921dd379006471a4b: soundwire: intel: add clock stop quirks (2019-12-12 09:17:07 +0530) ---------------------------------------------------------------- SoundWire tag for ASoC This contains the recently merged soundwire interface changes for ASoC subsystem. ---------------------------------------------------------------- Bard Liao (2): soundwire: intel: update headers for interrupts soundwire: intel: add link_list to handle interrupts with a single thread Pierre-Louis Bossart (7): soundwire: sdw_slave: add probe_complete structure and new fields soundwire: sdw_slave: add enumeration_complete structure soundwire: sdw_slave: add initialization_complete definition soundwire: sdw_slave: track unattach_request to handle all init sequences soundwire: intel: update interfaces between ASoC and SoundWire soundwire: intel: add mutex for shared SHIM register access soundwire: intel: add clock stop quirks Rander Wang (2): soundwire: intel: update stream callbacks for hwparams/free stream operations soundwire: intel: add prototype for WAKEEN interrupt processing drivers/soundwire/intel.c | 20 ++++++++++++++------ drivers/soundwire/intel.h | 13 ++++++++----- drivers/soundwire/intel_init.c | 32 ++++++++------------------------ include/linux/soundwire/sdw.h | 19 +++++++++++++++++++ include/linux/soundwire/sdw_intel.h | 156 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------- 5 files changed, 196 insertions(+), 44 deletions(-) _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel