From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84077C433ED for ; Tue, 11 May 2021 16:32:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 016666190A for ; Tue, 11 May 2021 16:32:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 016666190A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 57E3E17D5; Tue, 11 May 2021 18:32:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 57E3E17D5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1620750775; bh=EO1IZfDalGC3qZ+lhO1JESCbC0ZvO+bNicZISTYV+5o=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NIJ+rPVkwVKh30e8t6P0SSOQgvBxiNEALKX3gZCEeHXVvL3N4/3p8nMYPUeLg/CZc uYRKSILLU8aXnsaLbVPyD+AVxbQB/WrTRkbTvfPcfWlRSy5hXdDBYuVYyV/Zrl1H5k MKE97MmsYwzp/evEfExu9ZO+ej0p7MLvgvWAEC7E= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D09FBF800E9; Tue, 11 May 2021 18:32:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 31FDEF80163; Tue, 11 May 2021 18:31:57 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 28340F800E9 for ; Tue, 11 May 2021 18:31:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 28340F800E9 IronPort-SDR: WxYTr8VatUzDkGsD1idqCDufwSM5OW1Z/mNkQo2fA3NfSttnDJu6lwKMCKMaV5GGfFpbWGFf9V kIdBhjlOFrDA== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="179080593" X-IronPort-AV: E=Sophos;i="5.82,291,1613462400"; d="scan'208";a="179080593" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 09:31:43 -0700 IronPort-SDR: KRxtLJn+R4q5VYaBdknj+YzPZ2VUeVy2jmNZyAZlZdMtEsxNCrbicBe8A3kCuDt5QjNxVzIy5w 9vAvDjVMeZgA== X-IronPort-AV: E=Sophos;i="5.82,291,1613462400"; d="scan'208";a="537094135" Received: from imascare-mobl.amr.corp.intel.com (HELO [10.212.18.238]) ([10.212.18.238]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 09:31:41 -0700 Subject: Re: [PATCH 1/3] ASoC: cs35l36: Remove unneeded variable initialisation To: Charles Keepax , broonie@kernel.org References: <20210511101051.17726-1-ckeepax@opensource.cirrus.com> From: Pierre-Louis Bossart Message-ID: Date: Tue, 11 May 2021 11:31:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210511101051.17726-1-ckeepax@opensource.cirrus.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org, david.rhodes@cirrus.com, lgirdwood@gmail.com, james.schulman@cirrus.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 5/11/21 5:10 AM, Charles Keepax wrote: > Reported-by: Pierre-Louis Bossart > Signed-off-by: Charles Keepax Thanks, I rechecked with this patchset applied on top of the previous one, there's only one warning left: sound/soc/codecs/cs42l56.c:1308:6: style: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment] ret = devm_snd_soc_register_component(&i2c_client->dev, ^ sound/soc/codecs/cs42l56.c:1247:6: note: ret is assigned ret = regmap_read(cs42l56->regmap, CS42L56_CHIP_ID_1, ®); ^ sound/soc/codecs/cs42l56.c:1308:6: note: ret is overwritten ret = devm_snd_soc_register_component(&i2c_client->dev, ^ > --- > sound/soc/codecs/cs35l36.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c > index a038bcec2d17c..db5472b10465b 100644 > --- a/sound/soc/codecs/cs35l36.c > +++ b/sound/soc/codecs/cs35l36.c > @@ -1156,7 +1156,7 @@ static int cs35l36_component_probe(struct snd_soc_component *component) > { > struct cs35l36_private *cs35l36 = > snd_soc_component_get_drvdata(component); > - int ret = 0; > + int ret; > > if ((cs35l36->rev_id == CS35L36_REV_A0) && cs35l36->pdata.dcm_mode) { > regmap_update_bits(cs35l36->regmap, CS35L36_BSTCVRT_DCM_CTRL, >