Re: [PATCH 0/3] ALSA: hda: bus cleanup

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

On 8/8/19 4:57 AM, Takashi Iwai wrote:
> Hi,
> 
> this is a few patches to simplify and cleanup the HD-audio bus ops.
> 
> The first two patches translate the indirect calls of DMA page
> allocation and MMIO accesses with the direct ones, as well as
> eliminating the whole bus->io_ops.
> 
> The last one is SOF-specific, and fixes/cleans up by calling the
> proper hdaudio bus init function, as formerly discussed.

This is a good cleanup, thanks Takashi.

For the series

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

One request from me since I am lazy: could we somehow merge branches 
between you / Mark since at the moment we have two sets of conflicts 
(NHLT and this one). We test all the upstream changes on hardware as 
soon as we can, and manual conflict resolution makes it slower/more 
error prone.

> 
> 
> Takashi
> 
> ===
> 
> Takashi Iwai (3):
>    ALSA: hda: Remove page allocation redirection
>    ALSA: hda: Direct MMIO accesses
>    ASoC: SOF: Intel: Initialize hdaudio bus properly
> 
>   include/sound/hdaudio.h                | 69 +++++++++++++--------------
>   include/sound/hdaudio_ext.h            |  1 -
>   sound/hda/Kconfig                      |  3 ++
>   sound/hda/ext/hdac_ext_bus.c           | 60 +-----------------------
>   sound/hda/hdac_bus.c                   | 36 ++++++++++++--
>   sound/hda/hdac_controller.c            | 18 +++----
>   sound/hda/hdac_stream.c                |  8 ++--
>   sound/pci/hda/Kconfig                  |  1 +
>   sound/pci/hda/hda_controller.c         |  6 +--
>   sound/pci/hda/hda_controller.h         |  3 +-
>   sound/pci/hda/hda_intel.c              | 71 ++--------------------------
>   sound/pci/hda/hda_tegra.c              | 84 +--------------------------------
>   sound/soc/intel/skylake/skl-messages.c | 15 +-----
>   sound/soc/intel/skylake/skl.c          |  7 ++-
>   sound/soc/sof/intel/hda-bus.c          | 85 ++++------------------------------
>   sound/soc/sof/intel/hda-dsp.c          |  2 +-
>   sound/soc/sof/intel/hda.c              |  6 +--
>   sound/soc/sof/intel/hda.h              |  3 +-
>   18 files changed, 107 insertions(+), 371 deletions(-)
>