Re: [PATCH 3/3] ASoC: intel: skylake: Set max DMA segment size

[Cezary Rojewski <cezary.rojewski@intel.com>]

On 2022-02-15 2:27 PM, Takashi Iwai wrote:
> The recent code refactoring to use the standard DMA helper requires
> the max DMA segment size setup for SG list management.  Without it,
> the kernel may spew warnings when a large buffer is allocated.
> 
> This patch sets up dma_set_max_seg_size() for avoiding spurious
> warnings.


Thanks for accounting for skylake-driver when providing fixes.

Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>

> Fixes: 2c95b92ecd92 ("ALSA: memalloc: Unify x86 SG-buffer handling (take#3)")
> Cc: <stable@vger.kernel.org>
> BugLink: https://github.com/thesofproject/linux/issues/3430
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>   sound/soc/intel/skylake/skl.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
> index 148ddf4cace0..aeca58246fc7 100644
> --- a/sound/soc/intel/skylake/skl.c
> +++ b/sound/soc/intel/skylake/skl.c
> @@ -952,6 +952,7 @@ static int skl_first_init(struct hdac_bus *bus)
>   	/* allow 64bit DMA address if supported by H/W */
>   	if (dma_set_mask_and_coherent(bus->dev, DMA_BIT_MASK(64)))
>   		dma_set_mask_and_coherent(bus->dev, DMA_BIT_MASK(32));
> +	dma_set_max_seg_size(bus->dev, UINT_MAX);
>   
>   	/* initialize streams */
>   	snd_hdac_ext_stream_init_all