Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Geraldo Nascimento <geraldogabriel@gmail.com>
To: "João Miguel" <jmiguel.ghp@gmail.com>
Cc: Vijendar.Mukunda@amd.com, linux-sound@vger.kernel.org,
	alsa-devel@alsa-project.org,
	"João Miguel" <joaomiguel.sapientia@gmail.com>
Subject: Re: [PATCH] ASoC: amd: yc: Enable internal mic on MSI Bravo 17 C7VF
Date: Sat, 23 May 2026 17:58:29 -0300	[thread overview]
Message-ID: <ahIU9X2DizdyQVR8@geday> (raw)
In-Reply-To: <20260523163652.18499-1-jmiguel.ghp@gmail.com>

Hi João Miguel,

On Sat, May 23, 2026 at 05:36:52PM +0100, João Miguel wrote:
> From: João Miguel <joaomiguel.sapientia@gmail.com>
> 
> the board's internal DMIC is on the ACP6x and isn't detected without a DMI quirk entry; this adds it.
> ---
>  sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>

While the patch itself looks OK, you're missing the required
Signed-off-by tag, which should contain your legal name with surname
(I'm assuming Miguel is not your surname, correct me if I'm wrong).

Also, please wrap the commit message at 72 characters. The way it is
now makes a very long line hard to read in standard terminals.

Thank you,
Geraldo Nascimento

> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 7a637d6b5..a93a7fd48 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -794,6 +794,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "M7601RM"),
>  		}
>  	},
> +	{
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."),
> +			DMI_MATCH(DMI_BOARD_NAME, "MS-17LN"),
> +		}
> +	},
>  	{}
>  };
>  
> -- 
> 2.54.0
> 
> 

  reply	other threads:[~2026-05-25  9:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-23 16:36 [PATCH] ASoC: amd: yc: Enable internal mic on MSI Bravo 17 C7VF João Miguel
2026-05-23 20:58 ` Geraldo Nascimento [this message]
2026-05-23 21:00   ` João Miguel
  -- strict thread matches above, loose matches on Subject: below --
2026-05-23 21:35 João Miguel
2026-06-01 16:20 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahIU9X2DizdyQVR8@geday \
    --to=geraldogabriel@gmail.com \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jmiguel.ghp@gmail.com \
    --cc=joaomiguel.sapientia@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox