From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: Nikhil Mahale <nmahale@nvidia.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.com, aplattner@nvidia.com
Subject: Re: [alsa-devel] [PATCH v1 2/5] ALSA: hda - Add DP-MST jack support
Date: Thu, 14 Nov 2019 12:46:34 +0200 (EET) [thread overview]
Message-ID: <alpine.DEB.2.21.1911141241280.16459@zeliteleevi> (raw)
In-Reply-To: <20191114033704.18171-3-nmahale@nvidia.com>
Hi Nikhil,
On Thu, 14 Nov 2019, Nikhil Mahale wrote:
> This patch adds DP-MST jack support which will be used on NVIDIA
> platforms. Today, DP-MST audio is supported only if the codec has
> acomp support. This patch makes it possible to add DP-MST support
> for non-acomp codecs.
[...]
> +++ b/sound/pci/hda/hda_generic.c
> @@ -4203,7 +4203,7 @@ static bool detect_pin_state(struct hda_codec *codec, hda_nid_t pin)
> {
> if (!is_jack_detectable(codec, pin))
> return true;
> - return snd_hda_jack_detect_state(codec, pin) != HDA_JACK_NOT_PRESENT;
> + return snd_hda_jack_detect_state(codec, pin, 0) != HDA_JACK_NOT_PRESENT;
> }
the patch adds quite a few checkpatch warnings. E.g. this line over
80 character limit. Run checkpatch yourself or take a look at e.g.
https://travis-ci.org/thesofproject/linux/jobs/611787177?utm_medium=notification&utm_source=github_status
I'll queued the series to SOF CI to do some testing against regressions
on our platforms. I'll report later if anything major found.
Br, Kai
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-14 10:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 3:36 [alsa-devel] [PATCH v1 0/5] ALSA: hda - Add DP-MST support for NVIDIA codecs Nikhil Mahale
2019-11-14 3:37 ` [alsa-devel] [PATCH v1 1/5] ALSA: hda - Rename snd_hda_pin_sense to snd_hda_jack_pin_sense Nikhil Mahale
2019-11-14 3:37 ` [alsa-devel] [PATCH v1 2/5] ALSA: hda - Add DP-MST jack support Nikhil Mahale
2019-11-14 10:46 ` Kai Vehmanen [this message]
2019-11-15 9:39 ` Nikhil Mahale
2019-11-14 10:54 ` Takashi Iwai
2019-11-15 9:46 ` Nikhil Mahale
2019-11-14 3:37 ` [alsa-devel] [PATCH v1 3/5] ALSA: hda - Add DP-MST conn list support Nikhil Mahale
2019-11-14 10:57 ` Takashi Iwai
2019-11-14 11:47 ` Nikhil Mahale
2019-11-14 13:14 ` Takashi Iwai
2019-11-15 9:52 ` Nikhil Mahale
2019-11-15 10:30 ` Takashi Iwai
2019-11-19 8:43 ` Nikhil Mahale
2019-11-14 3:37 ` [alsa-devel] [PATCH v1 4/5] ALSA: hda - Add DP-MST support for non-acomp codecs Nikhil Mahale
2019-11-14 3:37 ` [alsa-devel] [PATCH v1 5/5] ALSA: hda - Add DP-MST support for NVIDIA codecs Nikhil Mahale
2019-11-14 11:02 ` Takashi Iwai
2019-11-14 11:50 ` Nikhil Mahale
2019-11-14 13:15 ` Takashi Iwai
2019-11-14 10:38 ` [alsa-devel] [PATCH v1 0/5] " Takashi Iwai
2019-11-15 9:37 ` Nikhil Mahale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911141241280.16459@zeliteleevi \
--to=kai.vehmanen@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=aplattner@nvidia.com \
--cc=nmahale@nvidia.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox