From: Eldad Zack <eldad@fogrefinery.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Nikolay Martynov <mar.kolya@gmail.com>,
Clemens Ladisch <clemens@ladisch.de>,
alsa-devel@alsa-project.org, Daniel Mack <zonque@gmail.com>
Subject: Re: [PATCH v4 00/15] ALSA: usb-audio: fix playback/capture concurrent usage
Date: Mon, 7 Oct 2013 19:20:33 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1310071915350.1353@anubis> (raw)
In-Reply-To: <s5heh7xsa0d.wl%tiwai@suse.de>
On Mon, 7 Oct 2013, Takashi Iwai wrote:
> At Sun, 6 Oct 2013 22:31:05 +0200,
> Eldad Zack wrote:
> >
> > Hi,
> >
> > This patch series attempts to fix a long standing problem with the concurrent
> > usage of playback and capture on implicit feedback devices.
[snip]
>
> For reducing the further development, I applied trivial cleanup / fix
> patches now, namely, below have been merged now:
Thanks, Takashi!
> ALSA: usb-audio: remove unused parameter from sync_ep_set_params
> ALSA: usb-audio: remove deactivate_endpoints()
> ALSA: usb-audio: don't deactivate URBs on in-use EP
> ALSA: usb-audio: void return type of snd_usb_endpoint_deactivate()
> ALSA: usb-audio: clear SUBSTREAM_FLAG_SYNC_EP_STARTED on error
> ALSA: usb-audio: rename alt_idx to altsetting
> ALSA: usb-audio: remove unused endpoint flag EP_FLAG_ACTIVATED
>
> The patches below need trivial fixes:
> ALSA: usb-audio: prevent NULL dereference on stop trigger
> ALSA: usb-audio: improve logging messages
>
> And these need reconsideration:
> ALSA: usb-audio: always wait in start_endpoints
> ALSA: usb-audio: correct ep use_count semantics (add set_param flag)
>
> I'll check the rest later.
Thanks for the very fast response and the review! I'll try to fix all
the issues for the rest and repost.
Cheers,
Eldad
next prev parent reply other threads:[~2013-10-07 17:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 20:31 [PATCH v4 00/15] ALSA: usb-audio: fix playback/capture concurrent usage Eldad Zack
2013-10-06 20:31 ` [PATCH v4 01/15] ALSA: usb-audio: remove unused parameter from sync_ep_set_params Eldad Zack
2013-10-06 20:31 ` [PATCH v4 02/15] ALSA: usb-audio: remove deactivate_endpoints() Eldad Zack
2013-10-06 20:31 ` [PATCH v4 03/15] ALSA: usb-audio: prevent NULL dereference on stop trigger Eldad Zack
2013-10-07 8:57 ` Takashi Iwai
2013-10-06 20:31 ` [PATCH v4 04/15] ALSA: usb-audio: don't deactivate URBs on in-use EP Eldad Zack
2013-10-06 20:31 ` [PATCH v4 05/15] ALSA: usb-audio: void return type of snd_usb_endpoint_deactivate() Eldad Zack
2013-10-06 20:31 ` [PATCH v4 06/15] ALSA: usb-audio: clear SUBSTREAM_FLAG_SYNC_EP_STARTED on error Eldad Zack
2013-10-06 20:31 ` [PATCH v4 07/15] ALSA: usb-audio: correct ep use_count semantics (add set_param flag) Eldad Zack
2013-10-07 9:21 ` Takashi Iwai
2013-10-07 19:31 ` Eldad Zack
2013-10-08 7:01 ` Takashi Iwai
2013-10-06 20:31 ` [PATCH v4 08/15] ALSA: usb-audio: rename alt_idx to altsetting Eldad Zack
2013-10-06 20:31 ` [PATCH v4 09/15] ALSA: usb-audio: conditional interface altsetting Eldad Zack
2013-10-07 10:34 ` Takashi Iwai
2013-10-07 18:00 ` Eldad Zack
2013-10-07 18:23 ` Clemens Ladisch
2013-10-07 19:31 ` Takashi Iwai
2013-10-06 20:31 ` [PATCH v4 10/15] ALSA: usb-audio: conditional concurrent usage of endpoint Eldad Zack
2013-10-06 20:31 ` [PATCH v4 11/15] ALSA: usb-audio: remove altset_idx from snd_usb_substream Eldad Zack
2013-10-06 20:31 ` [PATCH v4 12/15] ALSA: usb-audio: remove unused endpoint flag EP_FLAG_ACTIVATED Eldad Zack
2013-10-06 20:31 ` [PATCH v4 13/15] ALSA: usb-audio: clear sync subs hw_params Eldad Zack
2013-10-06 20:31 ` [PATCH v4 14/15] ALSA: usb-audio: always wait in start_endpoints Eldad Zack
2013-10-07 9:26 ` Takashi Iwai
2013-10-07 19:26 ` Eldad Zack
2013-10-08 7:05 ` Takashi Iwai
2013-10-08 19:25 ` Eldad Zack
2013-10-06 20:31 ` [PATCH v4 15/15] ALSA: usb-audio: improve logging messages Eldad Zack
2013-10-07 9:23 ` Takashi Iwai
2013-10-07 9:30 ` [PATCH v4 00/15] ALSA: usb-audio: fix playback/capture concurrent usage Takashi Iwai
2013-10-07 17:20 ` Eldad Zack [this message]
2013-10-28 17:45 ` Nikolay Martynov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1310071915350.1353@anubis \
--to=eldad@fogrefinery.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=mar.kolya@gmail.com \
--cc=tiwai@suse.de \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).