[PATCH v2] sound: Disable the build of OSS drivers

[PATCH v2] sound: Disable the build of OSS drivers

[Takashi Iwai]

OSS drivers are left as badly unmaintained, and now we're facing a
problem to clean up the hackish set_fs() usage in their codes.  Since
most of drivers have been covered by ALSA, and the others are dead old
and inactive, let's leave them RIP.

This patch is the first step: disable the build of OSS drivers.
We'll eventually drop the whole codes and clean up later.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

v1->v2: Smaller changes, as Linus and Randy suggested.
	The first dmasound Kconfig inclusion is still commented out since
	it's shorter/simpler in the end.

 sound/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/Kconfig b/sound/Kconfig
index ee2e69a9ecd1..de23fc39cec8 100644
--- a/sound/Kconfig
+++ b/sound/Kconfig
@@ -54,7 +54,7 @@ config SOUND_OSS_CORE_PRECLAIM
 
 	  If unsure, say Y.
 
-source "sound/oss/dmasound/Kconfig"
+# source "sound/oss/dmasound/Kconfig"
 
 if !M68K && !UML
 
@@ -115,6 +115,7 @@ endif # SND
 menuconfig SOUND_PRIME
 	tristate "Open Sound System (DEPRECATED)"
 	select SOUND_OSS_CORE
+	depends on BROKEN
 	help
 	  Say 'Y' or 'M' to enable Open Sound System drivers.
 
-- 
2.12.2

Re: [PATCH v2] sound: Disable the build of OSS drivers

[Randy Dunlap]

On 05/11/17 13:58, Takashi Iwai wrote:
> OSS drivers are left as badly unmaintained, and now we're facing a
> problem to clean up the hackish set_fs() usage in their codes.  Since
> most of drivers have been covered by ALSA, and the others are dead old
> and inactive, let's leave them RIP.
> 
> This patch is the first step: disable the build of OSS drivers.
> We'll eventually drop the whole codes and clean up later.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

Tested-by: Randy Dunlap <rdunlap@infradead.org>


> ---
> 
> v1->v2: Smaller changes, as Linus and Randy suggested.
> 	The first dmasound Kconfig inclusion is still commented out since
> 	it's shorter/simpler in the end.
> 
>  sound/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/Kconfig b/sound/Kconfig
> index ee2e69a9ecd1..de23fc39cec8 100644
> --- a/sound/Kconfig
> +++ b/sound/Kconfig
> @@ -54,7 +54,7 @@ config SOUND_OSS_CORE_PRECLAIM
>  
>  	  If unsure, say Y.
>  
> -source "sound/oss/dmasound/Kconfig"
> +# source "sound/oss/dmasound/Kconfig"
>  
>  if !M68K && !UML
>  
> @@ -115,6 +115,7 @@ endif # SND
>  menuconfig SOUND_PRIME
>  	tristate "Open Sound System (DEPRECATED)"
>  	select SOUND_OSS_CORE
> +	depends on BROKEN
>  	help
>  	  Say 'Y' or 'M' to enable Open Sound System drivers.
>  
> 


-- 
~Randy

Re: [PATCH v2] sound: Disable the build of OSS drivers

[Geert Uytterhoeven]

Hi Iwai-san,

On Thu, May 11, 2017 at 10:58 PM, Takashi Iwai <tiwai@suse.de> wrote:
> OSS drivers are left as badly unmaintained, and now we're facing a
> problem to clean up the hackish set_fs() usage in their codes.  Since
> most of drivers have been covered by ALSA, and the others are dead old
> and inactive, let's leave them RIP.
>
> This patch is the first step: disable the build of OSS drivers.
> We'll eventually drop the whole codes and clean up later.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

> --- a/sound/Kconfig
> +++ b/sound/Kconfig
> @@ -54,7 +54,7 @@ config SOUND_OSS_CORE_PRECLAIM
>
>           If unsure, say Y.
>
> -source "sound/oss/dmasound/Kconfig"
> +# source "sound/oss/dmasound/Kconfig"

Please note the dmasound drivers do not have ALSA equivalents.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds