From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 958D6C54FCB for ; Thu, 23 Apr 2020 11:41:17 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 175BB20736 for ; Thu, 23 Apr 2020 11:41:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="gggKTvQ1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 175BB20736 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6E239168D; Thu, 23 Apr 2020 13:40:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6E239168D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587642075; bh=aH8nMyEXcwmUk4q9q32eE37lMkSzonAPVfjfVfsvfsA=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gggKTvQ1nqRgsM4QiGR2EE9Bsr6sCQPAUyRL3QAIN/HGsznMFTmK9DVTT8btImykB lrTPDK3oB2sRJfJrloid9SQkmAFm07H5XXmrzQ3iMdh8DLdKrdTNQWG7GGF63Yzy+A ABIc/a5qdgKd/LGuGnCATLDU3oycoQX5hJl6gPBE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E9517F8014A; Thu, 23 Apr 2020 13:40:24 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3A72DF801EC; Thu, 23 Apr 2020 13:40:23 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6E73AF800F2 for ; Thu, 23 Apr 2020 13:40:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6E73AF800F2 IronPort-SDR: JJYqUJGpEvFYT3x9b7L6zJM7sfIeCs1UUC419+NLxSavKti3eqoWB2e7e2oT9ZzmGIJeBqEydF N8uiASEC64Lw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 04:40:13 -0700 IronPort-SDR: Cj48xywAbMam1TqahufwyLNYPK3drQMRyar7exOjvQNwyzVM6INSxvAQx1vkJoAClrKIr5dTkC kMptHVGkY0pw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,307,1583222400"; d="scan'208";a="456877968" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.213.5.100]) ([10.213.5.100]) by fmsmga005.fm.intel.com with ESMTP; 23 Apr 2020 04:40:11 -0700 Subject: Re: [PATCH] ALSA: hda: Refactor Intel NHLT init To: Takashi Iwai References: <20200423112136.25207-1-cezary.rojewski@intel.com> From: Cezary Rojewski Message-ID: Date: Thu, 23 Apr 2020 13:40:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, broonie@kernel.org, tiwai@suse.com, pierre-louis.bossart@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2020-04-23 13:24, Takashi Iwai wrote: > On Thu, 23 Apr 2020 13:21:36 +0200, > Cezary Rojewski wrote: >> >> NHLT fetch based on _DSM prevents ACPI table override mechanism from >> being utilized. Make use of acpi_get_table to enable it and get rid of >> redundant code. >> >> Signed-off-by: Cezary Rojewski > > This looks like a nice cleanup and I'll happily apply if anyone can > test with the actual hardware -- currently mine has no DSP, so unable > to check. > > > thanks, > > Takashi > NHLT override method has been added for internal use half a year ago and is for some time the default method within our CI. This is tested on a wide spread of hardware, that is any Intel AVS archtecture, including production laptops. Actual override works like any SSDT/ DSDT, e.g. usage can be found at: https://github.com/thesofproject/acpi-scripts and original: https://wiki.up-community.org/Pinout_UP2#Installing_ACPI_overrides_to_enable_spi_in_userspace Early this year I've pushed the initiative to finally shatter bounds of mystery surrounding NHLT in Linux and make it available to community. Erik and Robert helped me in ACPICA part, patch link: https://patchwork.kernel.org/patch/11463235/ Spec can now be found at: https://01.org/blogs/intel-smart-sound-technology-audio-dsp This has been sanctioned by Intel Legal and acked by Marcin Obara, NHLT author so no worries about spec disappearing like it did in 2016. Czarek