From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00775C43334 for ; Mon, 11 Jul 2022 15:38:16 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8C1FE84B; Mon, 11 Jul 2022 17:37:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8C1FE84B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657553894; bh=ONEW7Q1Bxq9BGBlTir4WXCjSBO3Udt9JligkBzUDx8g=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nYPMs9MIj1qHHAJndCQvRsmPdnsrb7ajxMZCssO+fFpTP8dlg5UHdabJp99uXaZuT vhe5YuApQSuYOeM51pgyqbIyQY29pCdnvsia+T+OFmYznaMweIwJOsLg+iGdQ3EN2l 4vMhj3j62fzUU2VqvkaqFovUmbqO58WzvGglAaFA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 24F05F80155; Mon, 11 Jul 2022 17:37:24 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 62DCBF80163; Mon, 11 Jul 2022 17:37:22 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DC6C5F800E1 for ; Mon, 11 Jul 2022 17:37:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DC6C5F800E1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DrYWJxNO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657553840; x=1689089840; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ONEW7Q1Bxq9BGBlTir4WXCjSBO3Udt9JligkBzUDx8g=; b=DrYWJxNO7yZCzKb1GJM7az1f43fKkFYTvTbEf/G9N83Fe+cr5BrBgrZs gX3dexYXl/kcHhG5kn92oAQKYdDctXG5O/rHouoQzcyqUOFjJMBplP5Kp PlA41HucqaWjH0EyR7HGpunp7JDvzkzBAhbu6v5e0i+d+p9xnNtB26SYQ UohWnhirBogYeqnBlH2ZGmKIuabREnpcYeW++MQ9CwfzQdJlg7dUGBgn/ Re10sAKq7YZq3NFJ9nvv4DzETkUz3Lb9FS5UUzBhLTPqPwNrijPZ/phJ+ 2WTJWB8hOMyxWpXy4QOZEG+vZ0yUWlNi/Qp3/EOizwK5AeuPGKIvcYT3a Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10405"; a="285821520" X-IronPort-AV: E=Sophos;i="5.92,263,1650956400"; d="scan'208";a="285821520" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2022 08:37:13 -0700 X-IronPort-AV: E=Sophos;i="5.92,263,1650956400"; d="scan'208";a="921827284" Received: from jbeecha-mobl.amr.corp.intel.com (HELO [10.209.161.159]) ([10.209.161.159]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2022 08:37:12 -0700 Message-ID: Date: Mon, 11 Jul 2022 09:33:14 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.10.0 Subject: Re: Sound not working after commit bbf7d3b1c4f40eb02dd1dffb500ba00b0bff0303 on Amlogic A311D device Content-Language: en-US To: Alex Natalsson References: <15259e38-eccf-d294-a330-a48b5bbbdedf@linux.intel.com> <18d3e724-e43f-c166-e322-26cc5e3890b7@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: ALSA Development Mailing List , Kai Vehmanen , Takashi Iwai , =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= , Ranjani Sridharan , linux-sound@vger.kernel.org, Mark Brown , Bard Liao X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 7/9/22 06:19, Alex Natalsson wrote: >>> + if (!fe_substream) { >>> + dev_err(fe->dev, "%s: fe_substream not initialized\n", >>> __func__); >>> + return -EINVAL; >>> + } >>> + if (!be_substream) { >>> + dev_err(be->dev, "%s: be_substream not initialized\n", >>> __func__); >>> + return -EINVAL; >>> + } >>> + > > Will be this in upstream or needing bugzilla reporting message? I created a patch based on this, see https://github.com/thesofproject/linux/pull/3735 I am not sure however if this is the 'right' fix. There was a comment from Peter Ujfalusi that a BE substream may be initialized later, but if that's the case then the atomicity check that was introduced is done in the wrong location. Takashi, we could use your guidance here. Thanks -Pierre