From: Randy Dunlap <rdunlap@infradead.org>
To: Cezary Rojewski <cezary.rojewski@intel.com>, alsa-devel@alsa-project.org
Cc: lgirdwood@gmail.com, broonie@kernel.org, tiwai@suse.com,
pierre-louis.bossart@linux.intel.com
Subject: Re: [PATCH 2/2] ASoC: Intel: catpt: Add explicit DMADEVICES kconfig dependency
Date: Wed, 7 Oct 2020 09:25:55 -0700 [thread overview]
Message-ID: <b4895043-2a88-5eb2-443c-b5640bf90aee@infradead.org> (raw)
In-Reply-To: <20201007135701.20372-2-cezary.rojewski@intel.com>
On 10/7/20 6:57 AM, Cezary Rojewski wrote:
> catpt selects DW_DMAC_CORE which requires DMADEVICES. Fix unmet direct
> dependencies warning by updating driver's depends-on list.
>
> Fixes: 6cbfa11d2694 ("ASoC: Intel: Select catpt and deprecate haswell")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> sound/soc/intel/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index 1278bea4e1be..a5b446d5af19 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -21,7 +21,7 @@ config SND_SOC_INTEL_SST
> config SND_SOC_INTEL_CATPT
> tristate "Haswell and Broadwell"
> depends on ACPI || COMPILE_TEST
> - depends on SND_DMA_SGBUF
> + depends on DMADEVICES && SND_DMA_SGBUF
> select DW_DMAC_CORE
> select SND_SOC_ACPI_INTEL_MATCH
> help
>
--
~Randy
next prev parent reply other threads:[~2020-10-07 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 13:57 [PATCH 1/2] ASoC: Intel: catpt: Fix compilation when CONFIG_MODULES is disabled Cezary Rojewski
2020-10-07 13:57 ` [PATCH 2/2] ASoC: Intel: catpt: Add explicit DMADEVICES kconfig dependency Cezary Rojewski
2020-10-07 16:25 ` Randy Dunlap [this message]
2020-10-07 16:26 ` [PATCH 1/2] ASoC: Intel: catpt: Fix compilation when CONFIG_MODULES is disabled Randy Dunlap
2020-10-08 22:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4895043-2a88-5eb2-443c-b5640bf90aee@infradead.org \
--to=rdunlap@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).