From: "Wu, Songjun" <songjun.wu@atmel.com>
To: Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: atmel_ssc_dai.c, use of dai->id
Date: Tue, 5 Jul 2016 09:12:44 +0800 [thread overview]
Message-ID: <b50d70ac-a07f-2db5-7cc7-2cf7a23479f9@atmel.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1607041956420.11824@pmeerw.net>
On 7/5/2016 03:00, Peter Meerwald-Stadler wrote:
> Hello,
>
> I am trying to use SSC1 (not SSC0 which might work) on a SAMA5D4-Xplained
> board (4.1 kernel, but close to mainline)
>
> c706f2e5 ASoC: atmel_ssc_dai: distinguish the different SSC
> fixes an issue with cpu_dai id being always 0, while the ssc id should
> have been used (or the platform_device id)
>
> I think there is a remaining issue with DMA parameters in
> atmel_ssc_startup():
>
> line 324:
> dma_params = &ssc_dma_params[dai->id][dir];
>
> I think it should be
> dma_params = &ssc_dma_params[pdev->id][dir];
>
> I am new to this platform, please comment
> I can submit a formal patch later-on of course
>
Hi Peter,
Yes, you are right. It should be fixed in atmel_ssc_startup().
Thank you.
> thanks, regards, p.
>
prev parent reply other threads:[~2016-07-05 1:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 19:00 atmel_ssc_dai.c, use of dai->id Peter Meerwald-Stadler
2016-07-05 1:12 ` Wu, Songjun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b50d70ac-a07f-2db5-7cc7-2cf7a23479f9@atmel.com \
--to=songjun.wu@atmel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).