* atmel_ssc_dai.c, use of dai->id
@ 2016-07-04 19:00 Peter Meerwald-Stadler
2016-07-05 1:12 ` Wu, Songjun
0 siblings, 1 reply; 2+ messages in thread
From: Peter Meerwald-Stadler @ 2016-07-04 19:00 UTC (permalink / raw)
To: Nicolas Ferre; +Cc: alsa-devel, Mark Brown, linux-arm-kernel, Songjun Wu
Hello,
I am trying to use SSC1 (not SSC0 which might work) on a SAMA5D4-Xplained
board (4.1 kernel, but close to mainline)
c706f2e5 ASoC: atmel_ssc_dai: distinguish the different SSC
fixes an issue with cpu_dai id being always 0, while the ssc id should
have been used (or the platform_device id)
I think there is a remaining issue with DMA parameters in
atmel_ssc_startup():
line 324:
dma_params = &ssc_dma_params[dai->id][dir];
I think it should be
dma_params = &ssc_dma_params[pdev->id][dir];
I am new to this platform, please comment
I can submit a formal patch later-on of course
thanks, regards, p.
--
Peter Meerwald-Stadler
+43-664-2444418 (mobile)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: atmel_ssc_dai.c, use of dai->id
2016-07-04 19:00 atmel_ssc_dai.c, use of dai->id Peter Meerwald-Stadler
@ 2016-07-05 1:12 ` Wu, Songjun
0 siblings, 0 replies; 2+ messages in thread
From: Wu, Songjun @ 2016-07-05 1:12 UTC (permalink / raw)
To: Peter Meerwald-Stadler, Nicolas Ferre
Cc: alsa-devel, Mark Brown, linux-arm-kernel
On 7/5/2016 03:00, Peter Meerwald-Stadler wrote:
> Hello,
>
> I am trying to use SSC1 (not SSC0 which might work) on a SAMA5D4-Xplained
> board (4.1 kernel, but close to mainline)
>
> c706f2e5 ASoC: atmel_ssc_dai: distinguish the different SSC
> fixes an issue with cpu_dai id being always 0, while the ssc id should
> have been used (or the platform_device id)
>
> I think there is a remaining issue with DMA parameters in
> atmel_ssc_startup():
>
> line 324:
> dma_params = &ssc_dma_params[dai->id][dir];
>
> I think it should be
> dma_params = &ssc_dma_params[pdev->id][dir];
>
> I am new to this platform, please comment
> I can submit a formal patch later-on of course
>
Hi Peter,
Yes, you are right. It should be fixed in atmel_ssc_startup().
Thank you.
> thanks, regards, p.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-05 1:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-04 19:00 atmel_ssc_dai.c, use of dai->id Peter Meerwald-Stadler
2016-07-05 1:12 ` Wu, Songjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).