From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [alsa-devel] [PATCH] SoC: intel: byt: Introduce new custom IN2 map Date: Tue, 21 Nov 2017 09:12:16 -0600 Message-ID: References: <20171018164957.2270-1-carlo@caione.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Carlo Caione Cc: alsa-devel@alsa-project.org, Liam Girdwood , open list , Mark Brown , Carlo Caione , Linux Upstreaming Team List-Id: alsa-devel@alsa-project.org On 11/21/17 3:30 AM, Carlo Caione wrote: > On Thu, Nov 16, 2017 at 1:53 PM, Carlo Caione wrote: >> On Wed, Oct 18, 2017 at 7:05 PM, Pierre-Louis Bossart >> wrote: >>> On 10/18/17 11:49 AM, Carlo Caione wrote: >>>> >>>> From: Carlo Caione >>>> >>>> Introduce a new custom dapm routes map to quirk platforms with the >>>> internal mic connected to IN2P. >>> >>> >>> LGTM. If we start getting more quirks for this codec, we should think of >>> adding a module parameters to select them from the command line or with >>> modprobe (as done in other machine drivers). >> >> Hey Pierre, >> I'm currently working on a laptop (always with the rt5651 codec) >> having two separate internal mics (on IN1P and IN2P) and the headset >> on IN3P. I was thinking how to describe this situation in the current >> driver without having to add all the 6 different configuration as >> quirks. Any suggestion? The microphone configurations are not handled with a mask but an enum and the BYT_RT5651_MAP() macro. You can just add a new configuration such at BYT_RT5651_IN1_IN2 which uses the analog mics on those two and implicitly use IN3 for the headset. I don't see the point of handling all possible permutations at this point.